Refine error msg in paddle/fluid/framework/details [part 2] #27429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhiqiu
force-pushed
the
dev/refine_error_msg_in_details2
branch
from
8cfbf63
to
53b154b
Compare
zhiqiu
force-pushed
the
dev/refine_error_msg_in_details2
branch
from
0f62ca3
to
325c1b5
Compare
| platform::errors::InvalidArgument( | ||
| "The item at position %d of rows of SelectedRows is not equal to " | ||
| "the expected, expect %d, but got %d.", | ||
| k, rows[k], selected_rows.rows()[k])); |
There was a problem hiding this comment.
rows[k], selected_rows.rows()[k]) %ld
| PADDLE_THROW("Type %s of %s is not supported eager deletion", | ||
| framework::ToTypeName(var->Type()), var_info->Name()); | ||
| PADDLE_THROW(platform::errors::Unimplemented( | ||
| "The variable(%s) of type %s is not supported in eager deletion", |
| PADDLE_ENFORCE(remote.size() == vars.size()); | ||
| PADDLE_ENFORCE_EQ( | ||
| client->Gather(vars, &remote, *merged_dev_ctx, scope), true, | ||
| platform::errors::PreconditionNotMet("Gather() return false.")); |
There was a problem hiding this comment.
这个说网络通信错误之类的吧。不然函数是干啥的用户不知道啊~
Comment on lines
74
to
75
| platform::errors::PreconditionNotMet( | ||
| "The NoDummyInputSize should be equal to the number of places.")); |
Comment on lines
78
to
79
| platform::errors::PreconditionNotMet( | ||
| "The NoDummyInputSize and NoDummyOutputSize should be equal.")); |
| @@ -154,7 +186,8 @@ void SparseAllReduceOpHandle::RunImplEncoded() { | |||
| PADDLE_ENFORCE_EQ(paddle::communication::dgc::sparseReduce( | |||
| gather_buff, k, out_tensor_buf, | |||
| static_cast<int>(out_numel), nranks_, stream), | |||
| true); | |||
| true, platform::errors::Unavailable( | |||
| "Calling sparseReduce() failed.")); | |||
There was a problem hiding this comment.
函数名字说明了是以reduce方式进行稀释归约。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Refine error msg in paddle/fluid/framework/details, part 2.
Related #25631