error message optimization in softmax_with_cross_entropy_op #27772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
chenwhql
reviewed
Oct 12, 2020
| @@ -357,7 +357,8 @@ static void HardLabelSoftmaxWithCrossEntropy( | |||
| CALL_HARD_LABEL_SOFTMAX_WITH_CROSS_ENTROPY_FUSED_KERNEL(4); | |||
| CALL_HARD_LABEL_SOFTMAX_WITH_CROSS_ENTROPY_FUSED_KERNEL(2); | |||
| default: | |||
| PADDLE_THROW("BlockDim must be 2^n in softmax_with_cross_entropy_op"); | |||
| PADDLE_THROW(platform::errors::Unavailable( | |||
| "BlockDim must be 2^n in softmax_with_cross_entropy_op")); | |||
There was a problem hiding this comment.
建议BlockDim展开为完整的英语单词，比如Block Dimension？BlockDim是我们内部定义的变量，用户可能不清楚
建议结尾加句点
| @@ -397,7 +398,8 @@ static void SoftmaxWithCrossEntropyFusedKernel(const T* logits_data, | |||
| CALL_SOFTMAX_WITH_CROSS_ENTROPY_FUSED_KERNEL(4); | |||
| CALL_SOFTMAX_WITH_CROSS_ENTROPY_FUSED_KERNEL(2); | |||
| default: | |||
| PADDLE_THROW("BlockDim must be 2^n in softmax_with_cross_entropy_op"); | |||
| PADDLE_THROW(platform::errors::Unavailable( | |||
| "BlockDim must be 2^n in softmax_with_cross_entropy_op")); | |||
| "This kernel only runs on GPU device."); | ||
| PADDLE_ENFORCE_EQ( | ||
| platform::is_gpu_place(context.GetPlace()), true, | ||
| platform::errors::Unavailable("This kernel only runs on GPU device.")); |
There was a problem hiding this comment.
哪个kernel，建议避免使用this这种代词，用户不看代码可能不清楚this指代的是哪里？可以改成比如SoftmaxWithCrossEntropy operator's CUDA Kernel
| "This kernel only runs on GPU device."); | ||
| PADDLE_ENFORCE_EQ( | ||
| platform::is_gpu_place(context.GetPlace()), true, | ||
| platform::errors::Unavailable("This kernel only runs on GPU device.")); |
chen-zhiyu
pushed a commit
to chen-zhiyu/Paddle
that referenced
this pull request
Oct 15, 2020
…ddle#27772) * error message optimization in softmax_with_cross_entropy_op * fix some unsuited comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
Error message optimization in softmax_with_cross_entropy_op.cu.