tree-based-model #31696
Merged
tree-based-model #31696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tree-based-model
|
seiriosPlus
reviewed
Apr 6, 2021
| #include "paddle/fluid/operators/math/sampler.h" | ||
|
|
||
| namespace paddle { | ||
| namespace framework { |
seiriosPlus
reviewed
Apr 6, 2021
| namespace paddle { | ||
| namespace framework { | ||
|
|
||
| using Sampler = paddle::operators::math::Sampler; |
seiriosPlus
reviewed
Apr 6, 2021
| public: | ||
| virtual ~LayerWiseSampler() {} | ||
| explicit LayerWiseSampler(const std::string& name) { | ||
| tree_ = IndexWrapper::GetInstance()->GetTreeIndex(name); |
There was a problem hiding this comment.
singleton is necessary?
seiriosPlus
reviewed
Apr 6, 2021
| See the License for the specific language governing permissions and | ||
| limitations under the License. */ | ||
|
|
||
| #include <stdio.h> |
There was a problem hiding this comment.
FILE* fp = fopen(filename.c_str(), "rb")
seiriosPlus
reviewed
Apr 6, 2021
| if (item.key() == ".tree_meta") { | ||
| meta_.ParseFromString(item.value()); | ||
| } else { | ||
| auto code = boost::lexical_cast<uint64_t>(item.key()); |
There was a problem hiding this comment.
need to parse from bytes to uint64.
seiriosPlus
reviewed
Apr 6, 2021
| std::vector<uint64_t> get_travel_path(uint64_t child, uint64_t ancestor) { | ||
| std::vector<uint64_t> res; | ||
| while (child > ancestor) { | ||
| res.push_back(data_[child].id()); |
seiriosPlus
reviewed
Apr 6, 2021
| } | ||
| TreePtr tree = std::make_shared<TreeIndex>(); | ||
| int ret = tree->load(tree_path); | ||
| if (ret != 0) return; |
There was a problem hiding this comment.
if ret != 0 means loading tree_path fails, nothing need to do.
seiriosPlus
reviewed
Apr 12, 2021
| } | ||
| layer_counts_sum_ += layer_sample_num + 1; | ||
| layer_counts_.push_back(layer_sample_num); | ||
| VLOG(1) << "[INFO] level " << cur_layer |
seiriosPlus
reviewed
Apr 12, 2021
| int TreeIndex::Load(const std::string filename) { | ||
| int err_no; | ||
| auto fp = paddle::framework::fs_open_read(filename, &err_no, ""); | ||
| CHECK(fp != nullptr); |
seiriosPlus
reviewed
Apr 12, 2021
| uint64_t max_id_; | ||
| }; | ||
|
|
||
| using TreePtr = std::shared_ptr<TreeIndex>; |
There was a problem hiding this comment.
为什么使用 shared_ptr 不是 unique_ptr？
seiriosPlus
reviewed
Apr 12, 2021
|
|
||
| void insert_tree_index(const std::string name, const std::string tree_path) { | ||
| if (tree_map.find(name) != tree_map.end()) { | ||
| VLOG(0) << "Tree " << name << " has already existed."; |
seiriosPlus
reviewed
Apr 12, 2021
| WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}) | ||
| if (WITH_PSCORE) | ||
| add_custom_command(TARGET framework_py_proto POST_BUILD | ||
| COMMAND ${CMAKE_COMMAND} -E make_directory ${PADDLE_BINARY_DIR}/python/paddle/fluid/proto |
chalsliu
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
TreeBased统一支持方案基础功能组件：
当前所有基础组件需在WITH_DISTRIBUTED=ON时才可以使用。