[cmake] download_verify #33217
Merged
[cmake] download_verify #33217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
| @@ -8,44 +8,84 @@ if(WITH_GPU AND TENSORRT_FOUND) | |||
| set(INFERENCE_EXTRA_DEPS ${INFERENCE_EXTRA_DEPS} analysis ${analysis_deps}) | |||
| endif() | |||
|
|
|||
| function(download_data install_dir data_file) | |||
| function(download_data install_dir data_file url_verify) | |||
There was a problem hiding this comment.
url_verify 改成 checksum 感觉更好一些
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
增加了下载单测的模型、数据等文件的校验。如果下载失败会直接退出编译，不会等到编译完成后运行单测的时候再报错，提高CI的检测速度