Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set gradient_merge_cond persistable to false #35578

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Set gradient_merge_cond persistable to false #35578

merged 1 commit into from
Sep 10, 2021

Conversation

ZHUI
Copy link
Collaborator

@ZHUI ZHUI commented Sep 8, 2021 •
edited
Loading

PR types

Bug fixes

PR changes

Others

Describe

  1. gradient_merge_cond is not need to save as persistable.
  2. save op is not supported to save bool type

Old PR tries to fix this issue: #31752

@paddle-bot-old
Copy link

paddle-bot-old bot commented Sep 8, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

wangxicoding
wangxicoding approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@wangxicoding wangxicoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 47d15a3 into PaddlePaddle:develop Sep 10, 2021
@ZHUI ZHUI deleted the bugfix/save_gradient_merge_cond branch September 10, 2021 08:23
AnnaTrainingG pushed a commit to AnnaTrainingG/Paddle that referenced this pull request Sep 29, 2021
@ZHUI @AnnaTrainingG
set gradient_merge_cond persistable to false (PaddlePaddle#35578)
9318f34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangxicoding wangxicoding wangxicoding approved these changes

@sandyhouse sandyhouse Awaiting requested review from sandyhouse

@JZ-LIANG JZ-LIANG Awaiting requested review from JZ-LIANG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZHUI @wangxicoding