Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change the paddle.mm to matmul_v2 #35770

Merged
merged 4 commits into from
Oct 12, 2021
Merged

change the paddle.mm to matmul_v2 #35770

merged 4 commits into from
Oct 12, 2021

Conversation

wawltor
Copy link
Contributor

@wawltor wawltor commented Sep 15, 2021

PR types

Function optimization

PR changes

APIs

Describe

change the paddle.mm to matmul_v2

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jeff41404
Copy link
Contributor

should we modify the annotation in line 926: This op does not support broadcasting. See paddle.matmul ?

jeff41404
jeff41404 approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wawltor
Copy link
Contributor Author

wawltor commented Oct 12, 2021

should we modify the annotation in line 926: This op does not support broadcasting. See paddle.matmul ?

Yes，i delete this line.

@wawltor wawltor merged commit fba355f into PaddlePaddle:develop Oct 12, 2021
@wawltor wawltor mentioned this pull request Oct 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff41404 jeff41404 jeff41404 approved these changes

@TCChenlong TCChenlong TCChenlong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wawltor @jeff41404 @TCChenlong