Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【code format check upgrade】 step3：optimize installation and instruction of clang-format #43248

Merged
merged 1 commit into from
Jun 8, 2022
Merged

【code format check upgrade】 step3：optimize installation and instruction of clang-format #43248

merged 1 commit into from
Jun 8, 2022

Conversation

betterpig
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

Local installation of clang-format is not easy, optimize installation and instruction of it.

  • add default python version limit
    image
  • upgrade pip before pip install since low version pip does not have the source of clang-format whl.
    image
    after upgrade:
    image

@betterpig betterpig closed this Jun 8, 2022
@betterpig betterpig deleted the clang_format_hook branch June 8, 2022 06:26
@betterpig betterpig restored the clang_format_hook branch June 8, 2022 07:50
@betterpig betterpig reopened this Jun 8, 2022
luotao1
luotao1 approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 899efc4 into PaddlePaddle:develop Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@betterpig @luotao1