Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cmake-lint problems. #43406

Merged
merged 3 commits into from
Jun 14, 2022
Merged

fix cmake-lint problems. #43406

merged 3 commits into from
Jun 14, 2022

Conversation

jiweibo
Copy link
Contributor

@jiweibo jiweibo commented Jun 10, 2022

PR types

Others

PR changes

Others

Describe

cmake-lint

@paddle-bot-old
Copy link

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jiweibo jiweibo changed the title cmake-lint-1 fix cmake-lint problems. Jun 13, 2022
betterpig
betterpig approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@betterpig betterpig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

XiaoguangHu01
XiaoguangHu01 approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiweibo jiweibo merged commit 59f8923 into PaddlePaddle:develop Jun 14, 2022
@jiweibo jiweibo deleted the cmake_lint1 branch June 14, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shixiaowei02 Shixiaowei02 Shixiaowei02 approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@betterpig betterpig betterpig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiweibo @Shixiaowei02 @XiaoguangHu01 @betterpig