[Dy2St]Polish visit function in transformer #44083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
reviewed
Jul 7, 2022
| @@ -14,7 +14,8 @@ | |||
|
|
|||
| from paddle.utils import gast | |||
|
|
|||
| from paddle.fluid.dygraph.dygraph_to_static.origin_info import ORIGI_INFO | |||
| # Repeat the definition here to solve the problem of circular import | |||
| ORIGI_INFO = "Original information of source code for ast node." | |||
There was a problem hiding this comment.
我们可以把ORIGI_INFO定义放到utils.py 里？
There was a problem hiding this comment.
目前好像并不可以，如果放到utils.py里那么base_transformer.py和utils.py文件就需要互相import
TCChenlong
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
NOTE：有些transformer中visit_XX函数会直接向node中添加一些sub_node，比如return_transformer中的visit_Return，而且没有返回node，这样BaseTransformer的visti函数中添加报错信息的逻辑就无法生效