[PHI]Standardise some C++ API (Part5) #47860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
jiahy0825
approved these changes
Nov 15, 2022
zyfncg
reviewed
Nov 15, 2022
Comment on lines
+20
to
+26
| return KernelSignature("tril_triu", {"X"}, {"diagonal", "lower"}, {"Out"}); | ||
| } | ||
|
|
||
| KernelSignature TrilTriuGradOpArgumentMapping( | ||
| const ArgumentMappingContext& ctx) { | ||
| return KernelSignature( | ||
| "tril_grad", {"Out@GRAD"}, {"diagonal", "lower"}, {"X@GRAD"}); | ||
| "tril_triu_grad", {"Out@GRAD"}, {"diagonal", "lower"}, {"X@GRAD"}); |
There was a problem hiding this comment.
动静态图分别走两套kernel会不会埋下动静不一致的隐患？
There was a problem hiding this comment.
这个应该没有吧，类似于静态图走的addRawKernel，动态图走的addKernel
There was a problem hiding this comment.
目前感觉影响不大，不过按理说后面Raw和非Raw的kernel可能也需要尝试做一些整合
zyfncg
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
标准化hsigmoid_loss/layer_norm/matrix_rank/tril/triu c++ api，此PR是系列工作的最后一个PR
异构设备相关修改：PaddlePaddle/PaddleCustomDevice#204