Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][isort] introduce isort (part4) #48402

Merged
merged 4 commits into from
Nov 29, 2022

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Nov 25, 2022

PR types

Others

PR changes

Others

Describe

引入 isort 第四部分,格式化非单测部分代码(视情况可能进一步拆分……)

# 先修改配置移除剩下的非单测部分
isort .

因为出问题已经 revert 的一些目录,将会在之后 PR 查明问题并格式化:

  • python/paddle/tensor
  • python/paddle/common_ops_import.py(为解决上面的循环依赖而和上面一起修改,不在本 PR 修改)
  • python/paddle/utils/cpp_extension/cpp_extension.py 本 PR 直接加一个 isort: skip_file 解决

Note

为避免冲突,本 PR 不修改配置,将在主要 PR merge 后统一修改

Related links

@paddle-bot
Copy link

paddle-bot bot commented Nov 25, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Nov 25, 2022
@SigureMo SigureMo changed the title [WIP][CodeStyle][isort] introduce isort (part4) [CodeStyle][isort] introduce isort (part4) Nov 26, 2022
@luotao1 luotao1 self-assigned this Nov 28, 2022
@SigureMo SigureMo force-pushed the isort/fix/part4 branch 2 times, most recently from 31b5d03 to e60f7c6 Compare November 28, 2022 06:00
luotao1
luotao1 previously approved these changes Nov 29, 2022
XiaoguangHu01
XiaoguangHu01 previously approved these changes Nov 29, 2022
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor

luotao1 commented Nov 29, 2022

@SigureMo 请解决下冲突

@SigureMo SigureMo dismissed stale reviews from XiaoguangHu01 and luotao1 via 2b063b6 November 29, 2022 04:05
@SigureMo
Copy link
Member Author

@luotao1 这个 CI 也跑完啦~

@luotao1 luotao1 merged commit f85def9 into PaddlePaddle:develop Nov 29, 2022
@SigureMo SigureMo deleted the isort/fix/part4 branch November 29, 2022 10:57
@luotao1
Copy link
Contributor

luotao1 commented Nov 30, 2022

isort 工作也可以放到 Flake8 tracking issue 的其他成果中

@SigureMo
Copy link
Member Author

isort 工作也可以放到 Flake8 tracking issue 的其他成果中

嗯嗯,Flake8 tracking issue 有这一部分,不过后面的我还没整理,等 part6 merge 后我一起整理下~

lxsbupt pushed a commit to lxsbupt/Paddle that referenced this pull request Dec 17, 2022
* isort all files

* revert conflicting files

* revert conflicting files

* revert conflicting files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants