Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon No58】-fix atan2 #51185

Merged
merged 25 commits into from
Mar 17, 2023
Merged

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Mar 4, 2023

PR types

Others

PR changes

APIs

Describe

fix atan2

@paddle-bot
Copy link

paddle-bot bot commented Mar 4, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Mar 4, 2023
@enkilee
Copy link
Contributor Author

enkilee commented Mar 13, 2023

Not equal to tolerance rtol=0.04, atol=0.1
2023-03-12 20:53:32 Operator atan2 error, Gradient Check On Place(cpu) variable X1 (shape: (15, 17), dtype: <class 'numpy.uint16'>) max gradient diff over limit
2023-03-12 20:53:32 Mismatched elements: 5 / 255 (1.96%)
2023-03-12 20:53:32 Max absolute difference: 0.82210501
2023-03-12 20:53:32 Max relative difference: 17.1498574
2023-03-12 20:53:32 x: array([[0.00351 , 0.002609, 0.002441, 0.001801, 0.005524, 0.003143,
2023-03-12 20:53:32 0.015869, 0.003418, 0.002914, 0.002808, 0.002029, 0.004852,
2023-03-12 20:53:32 0.002625, 0.001396, 0.003036, 0.005829, 0.0019 ],...
2023-03-12 20:53:32 y: array([[0.002743, 0.001307, 0.001096, 0.001641, 0.002259, 0.005355,
2023-03-12 20:53:32 0.001338, 0.001244, 0.003658, 0.153945, 0.005613, 0.005016,
2023-03-12 20:53:32 0.001333, 0.002405, 0.00104 , 0.001005, 0.003632],...

想问下,像这种 绝对误差阈值 超了的,该如何着手分析?

@enkilee enkilee requested a review from ZzSean March 17, 2023 02:22
Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit b94fe95 into PaddlePaddle:develop Mar 17, 2023
@enkilee enkilee deleted the HackathonNo58_atan2 branch April 2, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants