【Hackathon 4th No.11】为 paddle 添加 Geometric Distribution API #51224

dasenCoding · 2023-03-06T05:37:19Z

PR types

New features

PR changes

APIs

Description

为 Paddle 添加几何分布 API，该PR包括了 API 实现的代码，以及动态测试和静态测试类。
原设计文档: PaddlePaddle/community#376
更正后的设计文档: PaddlePaddle/community#519
中文API文档: PaddlePaddle/docs#5816

…into api_geometric

paddle-bot · 2023-03-06T05:37:23Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

paddle-bot · 2023-03-06T05:37:28Z

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

…into api_geometric

dasenCoding · 2023-04-17T13:50:58Z

@cxxly 已经修改，麻烦再检查以下，感谢！

cxxly

LGTM

luotao1 · 2023-04-21T02:12:26Z

@dasenCoding 中文API文档需要补充下

jeff41404 · 2023-04-21T04:12:12Z

python/paddle/distribution/geometric.py

+            #        [1.41421354])
+    """
+
+    def __init__(self, probs=None):


probs should not be a parameter with default value None?

probs should not be a parameter with default value None?

Yes, here really should not set a default value for probs, i have fixed.

thanks for your review!

jeff41404 · 2023-04-21T04:18:29Z

in rfc, chapter 3: pytorch args should be logits instead of scale?

dasenCoding · 2023-04-21T07:29:14Z

in rfc, chapter 3: pytorch args should be logits instead of scale?

根据您的建议，已经在此PR中进行了修正：
PaddlePaddle/community#519

谢谢！

dasenCoding · 2023-04-21T07:32:56Z

@dasenCoding 中文API文档需要补充下

Geometric 的中文文档已经完成！

doc PR: PaddlePaddle/docs#5816

谢谢！

luotao1

#52999 (comment)
可以参考下这个说明，单测目录发生变化了要进行迁移

dasenCoding · 2023-04-25T07:26:50Z

#52999 (comment) 可以参考下这个说明，单测目录发生变化了要进行迁移

收到！谢谢！

…into api_geometric

dasenCoding · 2023-04-27T02:45:31Z

@cxxly 剩下两个CI没有通过，其他的都已经通过了，请您审查一下，感谢！

jeff41404

LGTM

sunzhongkai588 · 2023-04-27T07:32:47Z

python/paddle/distribution/geometric.py

+    Args:
+        probs (Real|Tensor): Probability parameter.
+            The value of probs must be positive. When the parameter is a tensor, probs is probability of success for each trial.
+


加一下返回（returns）的描述

加一下返回（returns）的描述

已添加！

sunzhongkai588 · 2023-04-27T07:35:54Z

python/paddle/distribution/geometric.py

+
+            .. code-block:: python
+
+            import paddle


代码部分统一再往后缩进，否则无法解析出代码

代码部分统一再往后缩进，否则无法解析出代码

已修复！

…into api_geometric

sunzhongkai588

LGTM

dasenCoding added 2 commits March 6, 2023 13:09

first commit api and test_class

fa3b3fd

Merge branch 'api_geometric' of http://github.com/dasenCoding/Paddle …

921cefa

…into api_geometric

paddle-bot bot added contributor External developers status: proposed labels Mar 6, 2023

dasenCoding added 2 commits March 6, 2023 14:08

fix CIcheck: code style

9b5fc87

fix CI check: code style

f73282c

luotao1 assigned luotao1, cxxly and Ligoml Mar 6, 2023

dasenCoding and others added 13 commits March 6, 2023 17:21

fix CI check: code style

738032f

fix CI check: code style

0fa3635

fix CI check: code style

7c3161b

fix CI check: build failed for rsample tests

3bde0b4

Merge branch 'PaddlePaddle:develop' into api_geometric

ee02925

fix CI check: build failed

5c9f43d

Merge branch 'api_geometric' of http://github.com/dasenCoding/Paddle …

31a40cf

…into api_geometric

fix CI check: code converage

48a6414

fix CI check: code style

1eaf47a

fix CI check: code style

4b15204

Merge branch 'PaddlePaddle:develop' into api_geometric

1b5299a

fix CI check: kl test failed

a339855

Merge branch 'api_geometric' of http://github.com/dasenCoding/Paddle …

1dc341d

…into api_geometric

dasenCoding mentioned this pull request Mar 8, 2023

【PaddlePaddle Hackathon 第四期】任务总览 #51281

Closed

dasenCoding and others added 4 commits March 8, 2023 22:27

Merge branch 'PaddlePaddle:develop' into api_geometric

21a8f94

fix CI check: Coverage

4b95595

Merge branch 'api_geometric' of http://github.com/dasenCoding/Paddle …

416efb6

…into api_geometric

fix CI check: Py3

ff02b3d

luotao1 added the API label Mar 10, 2023

fix 0D tensor

7439580

cxxly previously approved these changes Apr 20, 2023

View reviewed changes

jeff41404 reviewed Apr 21, 2023

View reviewed changes

dasenCoding mentioned this pull request Apr 21, 2023

【Hackathon 4th No.11】为 Paddle 新增 Geometric API -- Geometric 中文API doc PaddlePaddle/docs#5816

Merged

delete probs' default value/ fix sample/rsample's param

c3cdd69

dasenCoding dismissed cxxly’s stale review via c3cdd69 April 21, 2023 07:19

dasenCoding mentioned this pull request Apr 21, 2023

【Hackathon 4th No.11】修复 ” paddle.distribution.Geometric分布“ 设计文档 PaddlePaddle/community#519

Merged

Merge branch 'PaddlePaddle:develop' into api_geometric

8c9dfc6

luotao1 reviewed Apr 25, 2023

View reviewed changes

dasenCoding and others added 4 commits April 25, 2023 18:46

Merge branch 'PaddlePaddle:develop' into api_geometric

c8137f2

change geometric's test path

0482646

Merge branch 'api_geometric' of http://github.com/dasenCoding/Paddle …

5b81edb

…into api_geometric

Merge branch 'PaddlePaddle:develop' into api_geometric

d431496

jeff41404 previously approved these changes Apr 27, 2023

View reviewed changes

luotao1 assigned sunzhongkai588 Apr 27, 2023

sunzhongkai588 reviewed Apr 27, 2023

View reviewed changes

dasenCoding added 2 commits April 27, 2023 15:57

add class returns/ code indentation

8198dbf

Merge branch 'api_geometric' of http://github.com/dasenCoding/Paddle …

439d401

…into api_geometric

dasenCoding dismissed jeff41404’s stale review via 439d401 April 27, 2023 07:57

Merge branch 'PaddlePaddle:develop' into api_geometric

08f570a

sunzhongkai588 approved these changes Apr 28, 2023

View reviewed changes

luotao1 merged commit bca1b0c into PaddlePaddle:develop Apr 28, 2023

MayYouBeProsperous mentioned this pull request Nov 20, 2023

【Hackathon 5th No.20】为 Paddle 新增 Exponential 和 Gamma API -part #57899

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【Hackathon 4th No.11】为 paddle 添加 Geometric Distribution API #51224

【Hackathon 4th No.11】为 paddle 添加 Geometric Distribution API #51224

dasenCoding commented Mar 6, 2023 •

edited by luotao1

paddle-bot bot commented Mar 6, 2023

paddle-bot bot commented Mar 6, 2023

dasenCoding commented Apr 17, 2023

cxxly left a comment

luotao1 commented Apr 21, 2023

jeff41404 Apr 21, 2023 •

edited

dasenCoding Apr 21, 2023

jeff41404 commented Apr 21, 2023

dasenCoding commented Apr 21, 2023 •

edited

dasenCoding commented Apr 21, 2023

luotao1 left a comment

dasenCoding commented Apr 25, 2023

dasenCoding commented Apr 27, 2023

jeff41404 left a comment

sunzhongkai588 Apr 27, 2023

dasenCoding Apr 27, 2023

sunzhongkai588 Apr 27, 2023

dasenCoding Apr 27, 2023

sunzhongkai588 left a comment

【Hackathon 4th No.11】 为 paddle 添加 Geometric Distribution API #51224

【Hackathon 4th No.11】 为 paddle 添加 Geometric Distribution API #51224

Conversation

dasenCoding commented Mar 6, 2023 • edited by luotao1

PR types

PR changes

Description

paddle-bot bot commented Mar 6, 2023

paddle-bot bot commented Mar 6, 2023

dasenCoding commented Apr 17, 2023

cxxly left a comment

Choose a reason for hiding this comment

luotao1 commented Apr 21, 2023

jeff41404 Apr 21, 2023 • edited

Choose a reason for hiding this comment

dasenCoding Apr 21, 2023

Choose a reason for hiding this comment

jeff41404 commented Apr 21, 2023

dasenCoding commented Apr 21, 2023 • edited

dasenCoding commented Apr 21, 2023

luotao1 left a comment

Choose a reason for hiding this comment

dasenCoding commented Apr 25, 2023

dasenCoding commented Apr 27, 2023

jeff41404 left a comment

Choose a reason for hiding this comment

sunzhongkai588 Apr 27, 2023

Choose a reason for hiding this comment

dasenCoding Apr 27, 2023

Choose a reason for hiding this comment

sunzhongkai588 Apr 27, 2023

Choose a reason for hiding this comment

dasenCoding Apr 27, 2023

Choose a reason for hiding this comment

sunzhongkai588 left a comment

Choose a reason for hiding this comment

【Hackathon 4th No.11】为 paddle 添加 Geometric Distribution API #51224

【Hackathon 4th No.11】为 paddle 添加 Geometric Distribution API #51224

dasenCoding commented Mar 6, 2023 •

edited by luotao1

jeff41404 Apr 21, 2023 •

edited

dasenCoding commented Apr 21, 2023 •

edited