Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test Mv] legacy_test #51941

Merged
merged 1 commit into from
Mar 22, 2023
Merged

[Test Mv] legacy_test #51941

merged 1 commit into from
Mar 22, 2023

Conversation

Zheng-Bicheng
Copy link
Contributor

@Zheng-Bicheng Zheng-Bicheng commented Mar 21, 2023 •
edited

PR types

Others

PR changes

Others

Describe

移动单测目录

@Zheng-Bicheng
Copy link
Contributor Author

Zheng-Bicheng commented Mar 21, 2023 •
edited

修改介绍

  • 移动测试文件到 test/legacy_test目录
  • 阅读了原先的CMake文件后发现不能只单纯的移动CMakeList文件，否则会出现错误。问题出在原先的CMake先判断了是否开启了WITH_TESTING，然后才包含了测试文件夹。最优的修改应该在test/CMakeLists.txt中新增对WITH_TESTING 的判断，判断为ON后在包含测试文件夹。由于不确定test/cpp下的文件是否为必选测试项，因此只在test/legacy_test/CMakeLists.txt的基础上做增量修改。

@Zheng-Bicheng Zheng-Bicheng mentioned this pull request Mar 21, 2023
Closed
@Zheng-Bicheng
Copy link
Contributor Author

关联Issues

@Zheng-Bicheng
Copy link
Contributor Author

@tianshuo78520a

@paddle-bot paddle-bot bot added the contributor External developers label Mar 21, 2023
zhiqiu
zhiqiu approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 1617ba7 into PaddlePaddle:develop Mar 22, 2023
@Zheng-Bicheng Zheng-Bicheng mentioned this pull request Mar 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiu zhiqiu zhiqiu approved these changes

Assignees

@luotao1 luotao1

@zhiqiu zhiqiu

@tianshuo78520a tianshuo78520a

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Zheng-Bicheng @zhiqiu @luotao1 @tianshuo78520a