-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test Mv] quantization #51942
[Test Mv] quantization #51942
Conversation
修改介绍
|
关联Issues |
关联PR在PR中已经移动了 |
@zhiqiu @tianshuo78520a 两位大佬好,我看到
这两个问题应该都和我的PR没关系?有办法解决这两个问题吗。 |
该任务处于测试中,属于非Required,可以不用关心 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
请解决下冲突,因为 |
@tianshuo78520a 可以考虑在 |
@luotao1 这个放在末尾能解决问题吗?看上去好像还不能诶。冲突的原因应该是Git认为我修改的都是第12行,才导致冲突吧。因为修改的CMakeList.txt冲突的地方结构是包含在if语句中的,没啥好办法。
|
可以我提个PR哈 |
感谢涛姐,很好的解决办法🫡 |
add_subdirectory(book) | ||
add_subdirectory(custom_kernel) | ||
add_subdirectory(cpp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
按字母序的话,cpp在custom_kernel前面,不过可以后面改
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#52131 在这个PR里提了,先整合后面一次性改掉?我想写个程序来排序,靠人工手动一个一个排有点头疼。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在这个PR里提了,先整合后面一次性改掉
可以的
PR types
Others
PR changes
Others
Describe
移动单测目录