Add Gloo Gather Function #52334
Merged
Add Gloo Gather Function #52334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
sneaxiy
reviewed
Mar 31, 2023
| task.wait() | ||
|
|
||
| test_gather(0) | ||
| test_gather(1) |
There was a problem hiding this comment.
You assume that this ut would only run when world size is 2. If world size is not 2, this ut does not work.
| @@ -61,8 +61,6 @@ class SendRecvOptions { | |||
|
|
|||
| friend void send_recv(SendRecvOptions*); | |||
| }; | |||
|
|
|||
There was a problem hiding this comment.
You do not need to rename this file. Rename it back.
sneaxiy
reviewed
Apr 4, 2023
| const phi::DenseTensor& in_tensor, | ||
| const GatherOptions& opts, | ||
| bool sync_op, | ||
| bool use_calc_stream) { |
There was a problem hiding this comment.
Throw exception when use_calc_stream is true.
| @@ -210,6 +216,11 @@ class ProcessGroupGloo : public ProcessGroupWithoutStream { | |||
| return platform::DeviceContextPool::Instance().Get(place); | |||
| } | |||
|
|
|||
| phi::DeviceContext* GetDeviceContext(const Place& place, | |||
There was a problem hiding this comment.
An exception will be thrown if this method is not used.
There was a problem hiding this comment.
I add an exception when use_calc_stream is true.
sneaxiy
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
Add Gloo Gather Function