Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon】64. einsum 算子 fp16单测完善 #53722

Merged
merged 1 commit into from
May 18, 2023

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented May 11, 2023

PR types

Others

PR changes

Others

Description

einsum 算子 fp16单测完善
图片

@paddle-bot
Copy link

paddle-bot bot commented May 11, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels May 11, 2023
@paddle-bot
Copy link

paddle-bot bot commented May 11, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

for i in range(len(self.operands))
],
}
print(self.attrs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

去掉print语句

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

@@ -659,5 +660,58 @@ def test_shape(self):
)


def einsum_wrapper(a, b):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请在test_einsum_op.py中添加,fp16和bf16的单测各添加一个

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

图片

文档中写的是test_einsum_v2.py

bf16已有
图片

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不好意思,这个可能是当时统计有误,你这段代码在test_einsum_op.py是有重复的,而且这个文件里都是OpTest,所以最好还是在这里加,统一起见bf16也加一个OpTest吧,v2里是APITest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改test_einsum_op.py

Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit c3c8579 into PaddlePaddle:develop May 18, 2023
@co63oc co63oc deleted the einsum branch May 18, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants