Feature/mod op #5454
Closed
Feature/mod op #5454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends on the #5455, need the CopyToVector function. |
Merged
typhoonzero
reviewed
Nov 26, 2017
|
|
||
| REGISTER_OP_GPU_KERNEL( | ||
| elementwise_mod, | ||
| ops::ElementwiseModKernel<paddle::platform::GPUPlace, int>); |
There was a problem hiding this comment.
Since our python test is int32, here should be int. And many of our operators need to support multi-types. Duplicate the different types need to be supported in a more elegant manner.
#5646
| ElementwiseModOpMaker(framework::OpProto* proto, | ||
| framework::OpAttrChecker* op_checker) | ||
| : ElementwiseOpMaker(proto, op_checker) { | ||
| SetComment("Mod", "$Out = X % Y$"); |
There was a problem hiding this comment.
Comment is too simple. Maybe add some explains about the formular
| void Compute(const framework::ExecutionContext& ctx) const override { | ||
| using Tensor = framework::Tensor; | ||
|
|
||
| // only support Tensor % Scalar |
There was a problem hiding this comment.
The unit test's Y seems not a scalar?
|
Since you haven't replied for a long time, we have closed this issue/pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add mod operator