Feature/copytensor #5455
Merged
Feature/copytensor #5455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
typhoonzero
reviewed
Nov 20, 2017
paddle/framework/CMakeLists.txt
Outdated
| @@ -5,8 +5,13 @@ cc_library(ddim SRCS ddim.cc DEPS eigen3) | |||
| cc_test(ddim_test SRCS ddim_test.cc DEPS ddim) | |||
| nv_test(dim_test SRCS dim_test.cu DEPS ddim) | |||
|
|
|||
| # cc_library(tensor SRCS tensor.cc tensor_util.cc DEPS ddim place paddle_memory device_context) | |||
There was a problem hiding this comment.
No commented out codes please.
typhoonzero
reviewed
Nov 26, 2017
| @@ -0,0 +1,36 @@ | |||
| import unittest | |||
There was a problem hiding this comment.
should remove this file since or put under v2/fluid/test
There was a problem hiding this comment.
I have another PR in of #5454. which I can move this file to the correct place in that PR.
This PR is so huge and fragile, I think we can mark that and do it later.
|
please clear code before merge if code is too old |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4647
This PR contains
CopyFromandCopyFromVectorfrom Tensor interface and make them global functions #4647 , move utility function out of Tensor.