Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][CINN] fix Ruff lint errors (pyupgrade rules) #54988

Merged
merged 7 commits into from
Jul 3, 2023

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Jun 29, 2023

PR types

Others

PR changes

Others

Description

相关链接:

@paddle-bot
Copy link

paddle-bot bot commented Jun 29, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 29, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 29, 2023
@SigureMo SigureMo changed the title [codestyle] Fix ruff pyupgrade [CodeStyle][CINN] fix Ruff lint errors (pyupgrade rules) Jun 30, 2023
@@ -69,7 +69,7 @@ def init_case(self):
packed = pack(data.size * 'h', *data.flatten())
self.inputs = {"x": data}
self.outputs = {
"y": np.array(unpack('4i', packed), dtype='int32').reshape((4)),
"y": np.array(unpack('4i', packed), dtype='int32').reshape((4,)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是自动修复的?为什么修复后语义都变了呢?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

为什么我这里自动修复不是这样的?

@SigureMo
Copy link
Member

挂的流水线 rerun 下试试?看起来都与本 PR 无关

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,麻烦 rerun 下 PR-CI-ROCM-Compile,其余两条流水线等周一豁免

@luotao1 luotao1 merged commit 402e277 into PaddlePaddle:develop Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants