Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon 5th No.24】Add SubsetRandomSampler -part #57726

Merged
merged 10 commits into from
Nov 8, 2023
Merged

【Hackathon 5th No.24】Add SubsetRandomSampler -part #57726

merged 10 commits into from
Nov 8, 2023

Conversation

Asthestarsfalll
Copy link
Contributor

@Asthestarsfalll Asthestarsfalll commented Sep 25, 2023 •
edited
Loading

PR types

Others

PR changes

APIs

Description

Add SubsetRandomSampler
RFC：PaddlePaddle/community#648
docs: PaddlePaddle/docs#6285

@paddle-bot
Copy link

paddle-bot bot commented Sep 25, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 25, 2023
@Ligoml Ligoml mentioned this pull request Sep 26, 2023
Open
@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Oct 3, 2023

Sorry to inform you that da857e5's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Oct 11, 2023

Sorry to inform you that 7818d36's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@Asthestarsfalll Asthestarsfalll mentioned this pull request Oct 16, 2023
Merged
@Asthestarsfalll
Copy link
Contributor Author

@lxd-cumt 劳烦老师审核一下～

@Asthestarsfalll
Copy link
Contributor Author

@lxd-cumt 请问还有啥需要修改的吗？

lxd-cumt
lxd-cumt approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@lxd-cumt lxd-cumt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Oct 27, 2023

Sorry to inform you that bf121ba's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Nov 2, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation Nov 2, 2023
@luotao1
Copy link
Contributor

luotao1 commented Nov 3, 2023

@Asthestarsfalll 请解决下CodeStyle流水线的问题

jeff41404
jeff41404 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sunzhongkai588
sunzhongkai588 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

@luotao1 luotao1 changed the title 【Hackathon 5th No.24】Add SubsetRandomSampler 【Hackathon 5th No.24】Add SubsetRandomSampler -part Nov 8, 2023
@luotao1 luotao1 merged commit 34416e5 into PaddlePaddle:develop Nov 8, 2023
28 checks passed
@sunzhongkai588 sunzhongkai588 mentioned this pull request Nov 8, 2023
Merged
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@Asthestarsfalll
【Hackathon 5th No.24】Add SubsetRandomSampler -part (PaddlePaddle#57726)
9e2fae9
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
@Asthestarsfalll @SecretXV
【Hackathon 5th No.24】Add SubsetRandomSampler -part (PaddlePaddle#57726)
20e02b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff41404 jeff41404 jeff41404 approved these changes

@lxd-cumt lxd-cumt lxd-cumt approved these changes

@sunzhongkai588 sunzhongkai588 sunzhongkai588 approved these changes

Assignees

@luotao1 luotao1

@lxd-cumt lxd-cumt

@sunzhongkai588 sunzhongkai588

Labels
contributor External developers PaddlePaddle Hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Asthestarsfalll @luotao1 @jeff41404 @lxd-cumt @sunzhongkai588