【Hackathon 6th No.50】 support backward for pylayer op #63319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add utility func
|
你的PR提交成功，感谢你对开源项目的贡献! |
add vjp handler in `call_vjp` interface
fix bugs for segmentation error
MarioLulab
changed the title
Aurelius84
reviewed
Apr 15, 2024
| for (size_t index = 0; index < num_operands(); ++index) { | ||
| input_values.push_back(operand_source(index)); | ||
| } | ||
| return input_values; |
There was a problem hiding this comment.
Op是派生自OpBase，可以直接使用 return this->operation()->operands_source();
There was a problem hiding this comment.
直接使用 operand_source() 效果应该是一样的？
| } | ||
|
|
||
| PythonCallableRegistrar &PythonCallableRegistrar::GetInstance() { | ||
| static PythonCallableRegistrar instance; |
There was a problem hiding this comment.
Suggested change
| static PythonCallableRegistrar instance; | |
| thread_local static PythonCallableRegistrar instance; |
MarioLulab
changed the title
MarioLulab
changed the title
|
Sorry to inform you that 3e6eae1's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
|
Sorry to inform you that a129b5f's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
|
@MarioLulab 需要解决下冲突 |
MarioLulab
requested review from
SigureMo,
2742195759,
gouzil,
cxxly,
xiaoguoguo626807 and
changeyoung98
as code owners
luotao1
changed the title
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
May 11, 2024
…3319) * create manual_pylayer_op files and add utility func * add instance for py_callable, add vjp handler in `call_vjp` interface * add backward testcases and fix bugs for segmentation error * update testcases and fix bugs * legacy_test/test_static_pylayer.py -> pir * code polish * pre-commit * remove redundant combine op * update dy2graph utils * add dy2st support * code polish * phi::errors -> common::erros * code polist * pre-commit * pre-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Others
PR Types
New features
Description
manual_pylayer_op.ccandmanual_pylayer_op.hPcard-80565