Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"fix frigled test gradient of rnn" #7166

Merged
merged 2 commits into from
Jan 3, 2018
Merged

"fix frigled test gradient of rnn" #7166

merged 2 commits into from
Jan 3, 2018

Conversation

dzhwinter
Copy link
Contributor

test_layerGrad always failed in rnn related tests.

  1. The test threshold is too critical for the complex network.
  2. Since our Fluid contains a fresh implementation, so our main focus should be pay to Fluid RNN.

qingqing01
qingqing01 approved these changes Jan 3, 2018
View reviewed changes
Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dzhwinter dzhwinter merged commit 1954146 into PaddlePaddle:develop Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingqing01 qingqing01 qingqing01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzhwinter @qingqing01