Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inference example and unit-test for word2vec chapter #8206

Merged
merged 7 commits into from
Feb 9, 2018

Conversation

sidgoyal78
Copy link
Contributor

@sidgoyal78 sidgoyal78 commented Feb 7, 2018

Fix #8198
But this PR should be merged after #8058 is merged.

TODO:
- uncomment "skipping" tests code

@kexinzhao kexinzhao added the 预测 原名Inference,包含Capi预测问题等 label Feb 7, 2018
@Xreki
Copy link
Contributor

Xreki commented Feb 9, 2018

Need to update to the develop branch to fix the conflict. Also the definition of TestInference is modified in #8227 .

Copy link
Contributor

@kexinzhao kexinzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor comments can be fixed in future PR.

@@ -1,6 +1,5 @@
# Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserve.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# # Licensed under the Apache License, Version 2.0 (the "License");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# # -> #, and add a empty line above. This can be fixed in the NMT pr.

@sidgoyal78 sidgoyal78 merged commit 1961470 into PaddlePaddle:develop Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
预测 原名Inference,包含Capi预测问题等
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants