Double buffer for cpp reader #8841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzhwinter
reviewed
Mar 7, 2018
| write_pos_(0), | ||
| read_pos_(0) { | ||
| std::thread prefetch( | ||
| std::bind(&DoubleBufferReader::PrefetchThreadFunc, this)); |
There was a problem hiding this comment.
delete the bind is ok here.
| if (read_pos_ >= kDoubleBufferSize) { | ||
| read_pos_ = 0; | ||
| } | ||
| buffer_not_full_.notify_all(); |
There was a problem hiding this comment.
For there is only one producer and one consumer here, notify_all() and notify_one() is same.
| private: | ||
| void PrefetchThreadFunc(); | ||
|
|
||
| std::vector<std::vector<framework::LoDTensor>> buffer_; |
There was a problem hiding this comment.
Maybe a thread safe channel (queue) is better here.
There was a problem hiding this comment.
I'll take a look at that. Thanks.
dzhwinter
approved these changes
Mar 9, 2018
|
|
||
| prog = fluid.framework.Program() | ||
| block = prog.current_block() | ||
| startup_prog = fluid.framework.Program() |
There was a problem hiding this comment.
Why make the reader operator as a part of startup program?
There was a problem hiding this comment.
Because a reader should be created only once.
JiayiFeng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8847
Please review #8913 first.