Add partial_sum and partial_concat support #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yeliang2258
commented
Jul 1, 2022
•
yeliang2258
commented
- Add partial_sum and partial_concat support
yeliang2258
changed the title
jiangjiajun
requested changes
Jul 4, 2022
| if (in.Rank() != 2) { | ||
| Error() << "The input dim of partial_sum OP must be 2." << std::endl; | ||
| return -1; | ||
| } |
There was a problem hiding this comment.
这个提示“The input dim of partial_sum OP must be 2.”
如果是Paddle要求只能为2，则是这个提示；
如果是Paddle2ONNX只能支持为2，则提示为Error() << Only support input with rank = 2, but now rank of input is " << in.Rank() << std::endl;
| } | ||
| int64_t batch_size = input_info[0].shape[0]; | ||
| int64_t max_length = input_info[0].shape[1]; | ||
| for (auto in : input_info) { |
| if (in.shape[0] != batch_size || in.shape[1] != max_length) { | ||
| Error() | ||
| << "The batch_size and max_length of all inputs must be same in " + | ||
| OpType() + " OP." |
| } | ||
| if (max_length < start_index_) { | ||
| Error() << "start_index must be less than input len in " + OpType() + " OP." | ||
| << std::endl; |
jiangjiajun
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.