[OpAttr]Support to parse Attribute with type(Variable) in 2ONNX #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aurelius84
commented
Aug 16, 2022
| @@ -590,6 +638,7 @@ void PaddleParser::GetOpAttr(const paddle2onnx::framework::proto::OpDesc& op, | |||
| for (auto i = 0; i < op.attrs_size(); ++i) { | |||
| if (op.attrs(i).name() == name) { | |||
| found = true; | |||
| if (IsAttrVar(op, i)) break; | |||
There was a problem hiding this comment.
有些Op的Mapper中在构造时，会调用GetAttr获取默认值。当Attribute类型为Var时是无法获取到默认值的，故在此类接口中统一添加 IsAttrVar判断跳过的逻辑。
会在Mapper的OpSetX中自动触发IsAttrVar分支处理。
jiangjiajun
requested changes
Aug 16, 2022
jiangjiajun
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what's New?
正确性验证
在此回滚PR上：PaddlePaddle/Paddle#44658 验证了两个单测的正确性：