Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trainer] add dp_group and exclude_layer params #4930

Merged
merged 4 commits into from
Feb 23, 2023

Conversation

JunnYu
Copy link
Member

@JunnYu JunnYu commented Feb 22, 2023

PR types

PR changes

Description

  • <=2.4.1的paddle不支持dp_group 和 exclude_layer 参数
  • develop paddle新增 dp_group 和 exclude_layer 参数,其中 exclude_layer 设置 GroupNorm
  • GroupNorm与框架的PyLayer结合,就会出现下面的BUG,该BUG还没修复。
    bdd237875f9a61a1adcb754def20c130

@JunnYu JunnYu requested a review from ZHUI February 22, 2023 06:01
@paddle-bot
Copy link

paddle-bot bot commented Feb 22, 2023

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #4930 (0c3e9d5) into develop (9a00c15) will decrease coverage by 0.01%.
The diff coverage is 12.50%.

@@             Coverage Diff             @@
##           develop    #4930      +/-   ##
===========================================
- Coverage    46.34%   46.34%   -0.01%     
===========================================
  Files          448      448              
  Lines        64646    64652       +6     
===========================================
+ Hits         29961    29963       +2     
- Misses       34685    34689       +4     
Impacted Files Coverage Δ
paddlenlp/trainer/trainer.py 59.56% <12.50%> (-0.28%) ⬇️
paddlenlp/utils/downloader.py 65.04% <0.00%> (+0.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ZHUI
ZHUI previously approved these changes Feb 22, 2023
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI mentioned this pull request Feb 22, 2023
@JunnYu JunnYu merged commit cd0afab into PaddlePaddle:develop Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants