Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cherry-pick] #10441 #10512 #10593

Merged
merged 2 commits into from
Aug 14, 2023
Merged

[Cherry-pick] #10441 #10512 #10593

merged 2 commits into from
Aug 14, 2023

Conversation

moehuster
Copy link
Contributor

  • update: Using smart pointers instead of raw pointers
  • update: Usinig intuitive initialization of duration

@paddle-bot
Copy link

paddle-bot bot commented Aug 10, 2023

Thanks for your contribution!

This was referenced Aug 10, 2023
Merged
Merged
shiyutang
shiyutang approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@shiyutang shiyutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shiyutang
Copy link
Collaborator

There is some problem with the CI needs to fix, btw, will you be interested in participating in this task #10381 of #10223

@shiyutang shiyutang merged commit 549376e into PaddlePaddle:dygraph Aug 14, 2023
2 checks passed
@shiyutang shiyutang added Code PR is needed This issue could inspire a code PR Contributor PR is merged labels Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiyutang shiyutang Awaiting requested review from shiyutang

Assignees
No one assigned
Labels
Code PR is needed This issue could inspire a code PR contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moehuster @shiyutang