fix read hide files bug for reader bug #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tils/dataloader_instance.py
…y core/utils/dataloader_instance.py" This reverts commit 348042a.
fuyinno4
previously approved these changes
Aug 18, 2020
seiriosPlus
reviewed
Aug 18, 2020
core/trainers/framework/dataset.py
Outdated
| # use files and dirs | ||
| for file_name in files: | ||
| file_list.append(os.path.join(train_data_path, file_name)) | ||
| print(os.path.join(train_data_path, file_name)) |
There was a problem hiding this comment.
- 为什么要print
- 上次说的， 如果有包含隐藏文件，要打个warning， 也没打.
seiriosPlus
reviewed
Aug 18, 2020
core/trainers/framework/dataset.py
Outdated
| for x in os.listdir(train_data_path) | ||
| ] | ||
| # file_list = [ | ||
| # os.path.join(train_data_path, x) |
seiriosPlus
reviewed
Aug 18, 2020
core/utils/dataloader_instance.py
Outdated
| for file_name in files: | ||
| file_list.append(os.path.join(train_data_path, file_name)) | ||
| print(os.path.join(train_data_path, file_name)) | ||
| for dirs_name in dirs: |
seiriosPlus
reviewed
Aug 18, 2020
core/utils/dataloader_instance.py
Outdated
| dirs[:] = [d for d in dirs if not d[0] == '.'] | ||
| if (files == None and dirs == None): | ||
| return None | ||
| else: |
There was a problem hiding this comment.
Thanks, move this function to util.py
seiriosPlus
approved these changes
Aug 20, 2020
fuyinno4
approved these changes
Aug 21, 2020
wangzhen38
pushed a commit
to wangzhen38/PaddleRec
that referenced
this pull request
Aug 6, 2021
fix read hide files bug for reader bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a recursive function for avoiding reading hidden files in readers