-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature&Fix] Add sympy_to_func #505
Merged
zhiminzhang0830
merged 20 commits into
PaddlePaddle:develop
from
HydrogenSulfate:feature-sympy
Aug 30, 2023
Merged
[Feature&Fix] Add sympy_to_func #505
zhiminzhang0830
merged 20 commits into
PaddlePaddle:develop
from
HydrogenSulfate:feature-sympy
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3be132b
to
97513c3
Compare
97513c3
to
fee4553
Compare
11 tasks
ppsci/utils/sym_to_func.py
Outdated
|
||
|
||
class ConstantNode(Node): | ||
""" "Class for constant variable node in converted expression tree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多了一个 "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
zhiminzhang0830
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
主要修改点:
LinearElasticity
和NavierStokes
上的单测,测试结果如下其他:
LinearElasticity
内,未正确处理dim=2
而可能导致KeyError的情况;删除无用的navier_x/y/z
系列表达式,并修改相关单测@AndPuQing 有空可以review一下