[Feature] Replace python funcion with sympy expression #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
HydrogenSulfate
changed the title
HydrogenSulfate
force-pushed
the
cvt_pyfunc_to_sym
branch
from
efaf5e4
to
be67fb4
Compare
ppsci/equation/pde/navier_stokes.py
Outdated
| def __init__(self, nu: Union[float, Callable], rho: float, dim: int, time: bool): | ||
| def __init__( | ||
| self, | ||
| nu: Union[float, Callable], |
There was a problem hiding this comment.
后面代码中 nu 允许类型为 str, 类型提示需要修改下。其他变量也检查下有没有类似情况
ppsci/equation/pde/navier_stokes.py
Outdated
| invars = (t,) + invars | ||
| if dim == 3: | ||
| invars += (z,) | ||
|
|
||
| self.nu = nu | ||
| self.rho = rho |
There was a problem hiding this comment.
这两行代码中用的的 nu, rho 在后续代码中有修改，看是否需要把这两行放到修改后面
| @@ -33,15 +35,15 @@ class Poisson(base.PDE): | |||
| >>> pde = ppsci.equation.Poisson(2) | |||
| """ | |||
|
|
|||
| def __init__(self, dim: int): | |||
| def __init__(self, dim: int, detach_keys: Optional[Tuple[str, ...]] = None): | |||
| @@ -61,214 +62,114 @@ def __init__( | |||
| rho: float = 1, | |||
| dim: int = 3, | |||
| time: bool = False, | |||
| detach_keys: Optional[Tuple[str, ...]] = None, | |||
| dim: int, | ||
| q: float, | ||
| D: float, | ||
| detach_keys: Optional[Tuple[str, ...]] = None, |
There was a problem hiding this comment.
更新docstring, 检查类型提示
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
主要修改点：
Solver和expression其他：
normal_dot_vel为normal_dot_vecsp_parser的相关无用代码