update data format for graph #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquesqiao
reviewed
Dec 27, 2017
docs/graph_data_format.md
Outdated
| } | ||
| ], | ||
| "edge": [ | ||
| {"source": "x", "target": "1"}, |
There was a problem hiding this comment.
把label也加上吧
{"source": "x", "target": "1", "label": "x"}
jacquesqiao
previously approved these changes
Dec 27, 2017
daming-lu
previously approved these changes
Dec 27, 2017
docs/graph_data_format.md
Outdated
| } | ||
| ], | ||
| "edge": [ | ||
| {"source": "x", "target": "1", "label": "label1"}, |
| "data_type": "FLOAT", | ||
| "name": "Y", | ||
| "shape": [ | ||
| "1" |
There was a problem hiding this comment.
是否应该用至少二维维度？这样更generic？比如：
W1: 3 x 2
X: 2 x 1
B1: 3 x 1
？
There was a problem hiding this comment.
shape是一个vector, 比如 [1,2,3]就代表 1 X 2 X 3的三维矩阵，vector<int>足够表达任意维度了
There was a problem hiding this comment.
不好意思，我误解了，确实shape多几个维度更有代表性
daming-lu
requested changes
Dec 28, 2017
| } | ||
| ], | ||
| "edge": [ | ||
| {"source": "X", "target": "1", "label": "label1"}, |
There was a problem hiding this comment.
- 我们可以把 source -> from, target -> to
- 这个例子漏掉了从node出来的边，比如，第一个node有4条边
W1 -> node_0
B1 -> node_0
X -> node_0
node_0 -> H1 (出边漏掉了!) - 用名字 ”X" 不知道方不方便？ 我想可以用 类型+下标，比如 input_0, node_1 。看看前端怎么render方便。个人感觉如果用名字 “X"，”W2" 什么的，则需要用 map 来加速查找。既然我们已经有 array了，用下标比较方便。
There was a problem hiding this comment.
- 这个名称就不改了，之前的可视化，edge 都是 target， source。
- 理解是 "H1" 的作用就是连接 node 1 , node2.
- 这个name 是作为 keyid的，用来查找node，后端怎么取都行。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.