Connect text feature with back end #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #246 |
daming-lu
previously approved these changes
Mar 26, 2018
| @@ -304,6 +309,9 @@ struct Text { | |||
| Tablet tablet_; | |||
| }; | |||
|
|
|||
| /* | |||
| * Text reader. | |||
There was a problem hiding this comment.
Do we need this comment?
There was a problem hiding this comment.
This is to match with the comment style in other classes.
| if data_size <= num_records: | ||
| return data | ||
|
|
||
| span = float(data_size) / (num_records - 1) |
There was a problem hiding this comment.
if num_records == 1, it would 'div by 0'
There was a problem hiding this comment.
The num_records is like a constant, where is currently set to 100.
I will move it away from the parameter and set it into a const
Remove test log
jetfuel
force-pushed
the
connectTextFeatureWithBackEnd
branch
from
7c90cb3
to
d6b4a2e
Compare
|
@daming-lu Code, updated. |
daming-lu
approved these changes
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.