-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedding visualization #351
Merged
daming-lu
merged 7 commits into
PaddlePaddle:develop
from
jetfuel:embedding_visualization
Mar 30, 2018
Merged
Embedding visualization #351
daming-lu
merged 7 commits into
PaddlePaddle:develop
from
jetfuel:embedding_visualization
Mar 30, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daming-lu
reviewed
Mar 29, 2018
visualdl/logic/sdk.h
Outdated
} | ||
|
||
// Add all word vectors along with all labels | ||
// The index of lables should match with the index of word_embeddings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
labels.
visualdl/storage/storage.proto
Outdated
@@ -109,6 +109,7 @@ message Tablet { | |||
kImage = 2; | |||
kText = 3; | |||
kAudio = 4; | |||
kkEmbedding = 5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be 'kEmbedding'
daming-lu
approved these changes
Mar 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend:
Create the embedding log writer and reader.
User can add embeddings by supplying a words vectors and a label list.