Fix unit tests and make sure all unit tests pass #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daming-lu
reviewed
Apr 11, 2018
| @@ -132,40 +129,6 @@ TEST(Image, add_sample_test) { | |||
| CHECK_EQ(image2read.num_records(), num_steps); | |||
| } | |||
|
|
|||
| TEST(Image, add_sample_test) { | |||
There was a problem hiding this comment.
So we do not test Image?
There was a problem hiding this comment.
we do, its duplicated, add_sample_test already defined
| vector<float> data; | ||
| for (int j = 0; j < 3 * 5 * 5; j++) { | ||
| data.push_back(float(rand()) / RAND_MAX); | ||
| vector<int32_t> shape({16000, 2, 2}); |
There was a problem hiding this comment.
What is the reason of changing these numbers? What are their meanings? Just want to learn 😄
There was a problem hiding this comment.
last time I just copied image test and change to audio. Image test they use shape [5,5,3] to represent 5x5 h and w and 3 channels (RGB). In audio, the params are [sample_rate, sample_width, number of channels]
| vector<float> data; | ||
| for (int j = 0; j < 3 * 5 * 5; j++) { | ||
| data.push_back(float(rand()) / RAND_MAX); | ||
| vector<uint8_t> data; |
There was a problem hiding this comment.
The audio data we accept is vector of uint8_t type, so I randomly pick numbers from rand() % 256 to create a vector
daming-lu
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.