Fix graph bugs #391
Merged
Fix graph bugs #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetfuel
reviewed
Apr 12, 2018
| @@ -483,23 +486,7 @@ def add_edge(self, source, target, label, **kwargs): | |||
|
|
|||
| def draw_graph(model_pb_path, image_dir): | |||
There was a problem hiding this comment.
The function name doesn't apply anymore. Also the we no longer need image_dir.
There was a problem hiding this comment.
Yes. This will also be renamed in the cleanup PR.
| data = {'url': ''} | ||
| # TODO(daming-lu): rename variables because we switched from static graph generated by graphviz | ||
| # to d3/dagre drawn svg | ||
| if graph_image_path is not None: |
There was a problem hiding this comment.
Will we generate static image? We might be able to remove block
There was a problem hiding this comment.
Like the TODO mentioned, we need to rename and remove some stuff because we were using GraphViz previously. I will do it after the release
| else: | ||
| data = {'url': '/graphs/image'} | ||
| image_dir = os.path.join(args.logdir, "graphs") |
There was a problem hiding this comment.
image_dir seems un-necessary now.
There was a problem hiding this comment.
Yes. It will be removed in the code cleanup.
jetfuel
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: add slider for large graph
We need this because if the graph is too large, each node is too small to see clearly. See MNIST vs. SqueezeNet below:
MNIST:
SqueezeNet:
