Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/add big file check #55

Merged
merged 9 commits into from
Jan 4, 2018
Merged

feature/add big file check #55

merged 9 commits into from
Jan 4, 2018

Conversation

Superjomn
Copy link
Contributor

  • add a hook into pre-commit to detect big file larger than 1MB and reject
  • add a test in Travis-CI to detect big file

jacquesqiao
jacquesqiao approved these changes Jan 4, 2018
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@Superjomn Superjomn merged commit af54766 into PaddlePaddle:develop Jan 4, 2018
jacquesqiao pushed a commit to jacquesqiao/VisualDL that referenced this pull request Jan 12, 2018
@Superjomn
feature/add big file check (PaddlePaddle#55)
3c02910
jacquesqiao pushed a commit to jacquesqiao/VisualDL that referenced this pull request Jan 13, 2018
@Superjomn
feature/add big file check (PaddlePaddle#55)
12cdc90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacquesqiao jacquesqiao jacquesqiao approved these changes

@daming-lu daming-lu Awaiting requested review from daming-lu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Superjomn @jacquesqiao