Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add M3D-RPN model #4822

Merged
merged 5 commits into from
Sep 14, 2020
Merged

add M3D-RPN model #4822

merged 5 commits into from
Sep 14, 2020

Conversation

shuluoshu
Copy link
Contributor

@CLAassistant
Copy link

CLAassistant commented Aug 31, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

qingqing01
qingqing01 reviewed Sep 7, 2020
View reviewed changes
Copy link
Collaborator

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先把代码清理下吧

PaddleCV/3d_vision/M3D-RPN/lib/core.py Outdated
return paths


# def init_torch(rng_seed, cuda_seed):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clear code

PaddleCV/3d_vision/M3D-RPN/lib/core.py Outdated
tracker[id + '_obj'] = stat


# def next_iteration(loader, iterator):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to clear code

heavengate
heavengate reviewed Sep 9, 2020
View reviewed changes
PaddleCV/3d_vision/M3D-RPN/utils.py
self.stats = {}

def update(self, keys, values):
"""update"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删掉或者细化一下？

@qingqing01 qingqing01 merged commit 08f3c0b into PaddlePaddle:develop Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heavengate heavengate heavengate left review comments

@qingqing01 qingqing01 qingqing01 approved these changes

@lijianshe02 lijianshe02 Awaiting requested review from lijianshe02

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shuluoshu @CLAassistant @qingqing01 @heavengate