Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #532

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update dependencies #532

wants to merge 2 commits into from

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Jun 20, 2022

This PR updates all dependencies, most notably terraform SDK which reveals an error in recently added changes.

make testacc TEST=./pagerduty/ TESTARGS='-run=TestAccPagerDutyService_AlertContentGrouping'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./pagerduty/ -v -run=TestAccPagerDutyService_AlertContentGrouping -timeout 120m
=== RUN   TestAccPagerDutyService_AlertContentGrouping
    resource_pagerduty_service_test.go:206: Step 2/2 error: Check failed: Check 8/12 error: pagerduty_service.foo: list or set attribute 'alert_grouping_parameters.0.config' must be checked by element count key (alert_grouping_parameters.0.config.#) or element value keys (e.g. alert_grouping_parameters.0.config.0). Set element value checks should use TestCheckTypeSet functions instead.
--- FAIL: TestAccPagerDutyService_AlertContentGrouping (14.37s)
FAIL
FAIL    github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   14.381s
FAIL
make: *** [GNUmakefile:17: testacc] Error 1

Note: this PR is just the result from running go get -u ./... && go mod tidy && go mod vendor

@pdecat
Copy link
Contributor Author

pdecat commented Jun 20, 2022

@pdecat
Copy link
Contributor Author

pdecat commented Jul 13, 2022

As I suggested in #525 (comment),
maybe vendored dependencies should be dropped altogether to only rely on golang modules with go.sum, and avoid having so many files impacted on dependencies updates.

@pdecat pdecat force-pushed the update_deps branch 4 times, most recently from 7296646 to 14e90e3 Compare July 23, 2022 08:14
@@ -1,13 +1,68 @@
module github.com/terraform-providers/terraform-provider-pagerduty

go 1.16
go 1.18
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching to go 1.18 is required by newer hcl v2 version:

Without this:

make testacc TEST=./pagerduty/ TESTARGS='-run=TestAccPagerDutyService_AlertContentGrouping'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./pagerduty/ -v -run=TestAccPagerDutyService_AlertContentGrouping -timeout 120m
# github.com/hashicorp/hcl/v2
vendor/github.com/hashicorp/hcl/v2/diagnostic_typeparams.go:22:22: type parameter requires go1.18 or later (-lang was set to go1.16; check go.mod)
vendor/github.com/hashicorp/hcl/v2/diagnostic_typeparams.go:22:24: undeclared name: any (requires version go1.18 or later)
FAIL    github.com/terraform-providers/terraform-provider-pagerduty/pagerduty [build failed]
FAIL
make: *** [GNUmakefile:17: testacc] Error 2

See hashicorp/hcl@c3b6715#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R3
and hashicorp/hcl@88ecd13#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R3

@NargiT
Copy link
Contributor

NargiT commented Aug 23, 2023

I would like to see this PR finished and merged. Such an important piece of the infrastructure cannot be left with old dependencies. (rf: #732)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants