Skip to content
This repository has been archived by the owner on Dec 14, 2019. It is now read-only.

Commit

Permalink
Closes #158 and Closes #156 - updating normalize scss
Browse files Browse the repository at this point in the history
  • Loading branch information
Kyle Andrews committed May 17, 2019
1 parent 9724ce6 commit 9c138eb
Show file tree
Hide file tree
Showing 23 changed files with 32 additions and 12 deletions.
14 changes: 11 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,24 @@
## 0.1.4 - Unreleased

### Fixed

- Fixes: changelog heading sizes
- Fixes: `normalize.scss` line heights and inline elements display values [#158](https://github.com/Pageworks/papertrain/issues/158)
- Fixes: input border radius defaults to `0px` [#156](https://github.com/Pageworks/papertrain/issues/156)

## 0.1.3.3 - 2019-05-14

## Fixed
### Fixed

- Fixes: setup test email address validation bug

## 0.1.3.2 - 2019-05-14

## Added
### Added

- Adds: setup script requires the developers email address and sets it as the `testToEmailAddress` in `general.php`

## Fixed
### Fixed

- Fixes: outstanding merge conflict issue from the previous release

Expand Down
4 changes: 2 additions & 2 deletions config/general.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
'useProjectConfigFile' => true,

// Leave at bottom of global settings
'jsCacheBustTimestamp' => '54654843',
'cssCacheBustTimestamp' => '54655693',
'jsCacheBustTimestamp' => '98165515',
'cssCacheBustTimestamp' => '98166328',
],

// Dev environment settings
Expand Down
1 change: 0 additions & 1 deletion public/assets/styles/main.54655693.css

This file was deleted.

1 change: 1 addition & 0 deletions public/assets/styles/main.98166328.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 18 additions & 6 deletions utils/styles/base/_normalize.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
vertical-align: baseline;
-webkit-tap-highlight-color: transparent;
position: relative;
line-height: 0;
line-height: 1;
}

body{
Expand All @@ -21,6 +21,19 @@ body{
}
}

span,
strong,
b,
i,
em,
s,
sub,
sup,
var{
line-height: 1.618;
display: inline;
}

script,
style{
display: initial !important;
Expand Down Expand Up @@ -122,6 +135,7 @@ fieldset{
outline: none;
font-size: 16px;
line-height: 1.618;
border-radius: 0;

&:focus,
&:active{
Expand Down Expand Up @@ -188,11 +202,9 @@ input[type="color"]::-webkit-color-swatch {
}

select{
html.has-js & {
appearance: none;
-moz-appearance: none;
-webkit-appearance: none;
}
appearance: none;
-moz-appearance: none;
-webkit-appearance: none;
}

fieldset{
Expand Down

0 comments on commit 9c138eb

Please sign in to comment.