Removes timeout option since we can't abort fetch

Pageworks · Apr 7, 2019 · ed01042 · ed01042
1 parent 59c297d
commit ed01042
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,7 @@
 ### Removes
 
 - Removes: no longer calls `lastChance()` when the new document contains `<script>` elements
+- Removes: `timeout` option from Pjax since we can't abort fetch
 
 # 1.3.0 - 2019-03-27
 

diff --git a/README.md b/README.md
@@ -75,7 +75,6 @@ You can define custom Pjax options using the following:
 | history                      | boolean                   | `true`               |
 | cacheBust                    | boolean                   | `false`              |
 | debug                        | boolean                   | `false`              |
-| timeout                      | number                    | `0`                  |
 | titleSwitch                  | boolean                   | `true`               |
 | customTransitions            | boolean                   | `false`              |
 | customPreventionAttributes   | string[]                  | `[]`                 |
@@ -92,8 +91,6 @@ When `history` is true Pjax will use `window.history.pushState()` to manipulate
 
 `debug` will tell Pjax to display all debug information.
 
-`timeout` is the about of time allowed before Pjax time's out an `XMLHttpRequest`
-
 `titleSwitch` when true will swap out the documents title during page transitions.
 
 `customTransitions` when true Pjax won't actually switch out the content until the developers application sends a custom `pjax:continue` event.

diff --git a/lib/parse-options.js b/lib/parse-options.js
diff --git a/lib/parse-options.js.map b/lib/parse-options.js.map
diff --git a/src/global.d.ts b/src/global.d.ts
@@ -14,7 +14,6 @@ declare namespace Pjax{
         history?:                       boolean;
         cacheBust?:                     boolean;
         debug?:                         boolean;
-        timeout?:                       number;
         titleSwitch?:                   boolean;
         customTransitions?:             boolean;
         customPreventionAttributes?:    Array<string>;

diff --git a/src/lib/parse-options.ts b/src/lib/parse-options.ts
@@ -10,7 +10,6 @@ export default (options:PJAX.IOptions = null)=>{
             parsedOptions.history                       = (options !== null && options.history !== undefined) ? options.history : true;
             parsedOptions.cacheBust                     = (options !== null && options.cacheBust !== undefined) ? options.cacheBust : false;
             parsedOptions.debug                         = (options !== null && options.debug !== undefined) ? options.debug : false;
-            parsedOptions.timeout                       = (options !== null && options.timeout !== undefined) ? options.timeout : 0;
             parsedOptions.titleSwitch                   = (options !== null && options.titleSwitch !== undefined) ? options.titleSwitch : true;
             parsedOptions.customTransitions             = (options !== null && options.customTransitions !== undefined) ? options.customTransitions : false;
             parsedOptions.customPreventionAttributes    = (options !== null && options.customPreventionAttributes !== undefined) ? options.customPreventionAttributes : [];