Macro hygeine #390
Merged
Macro hygeine #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
=======================================
Coverage 83.20% 83.20%
=======================================
Files 15 15
Lines 1280 1280
=======================================
Hits 1065 1065
Misses 215 215
Continue to review full report at Codecov.
|
|
Bump? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some fixes for more hygienic macros. It's good to be careful inside
escto interpolate in as much as possible, otherwise, you could accidentally end up referring to something in the user's namespace. In unescaped code, you can refer to things in your namespace safely.