Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit/ widget testing of the App. #326

Closed
arteevraina opened this issue Mar 15, 2021 · 16 comments
Closed

Improve unit/ widget testing of the App. #326

arteevraina opened this issue Mar 15, 2021 · 16 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@arteevraina
Copy link
Contributor

arteevraina commented Mar 15, 2021

Improving unit/widget testing of the app. Currently, the tests have been only been written for validators used in Register and Login Screens. I will help to improve the testing of the app and which would help to avoid any breaking changes in the future.

Folder: https://github.com/PalisadoesFoundation/talawa/tree/master/test

Other Information.

If mentors/ participants have anything to add to this issue. Please provide your valuable suggestions. I would keep that in mind while sending the patches. If you want to add any widget/unit test please update here before working.

@piyushpradhan
Copy link

I can help with writing widget tests.
If no one's currently working on it, can I take this up ?

@arteevraina
Copy link
Contributor Author

Hey @piyushpradhan ! Let's wait for the issue to get approved. If it gets approved, as I will be also working on this please update with widget are you working on in order to avoid any duplicate work.

@piyushpradhan
Copy link

Yeah, sure. We'll do that.

@jordanliu
Copy link
Contributor

Agreed, let's add some overflow tests as well. Assigning @arteevraina

@palisadoes palisadoes added the unapproved Unapproved, needs to be triaged label Mar 16, 2021
@jordanliu jordanliu removed the unapproved Unapproved, needs to be triaged label Mar 17, 2021
@arteevraina
Copy link
Contributor Author

@jordanliu Should I add overflow tests for all the screen in a single PR or handle create different PRs for different screens?

@Sagar2366
Copy link
Contributor

@arteevraina app testing is much needed issue to be fixed.
We should break down testing of each functionality in app.
For example - login screen test, sign up page tests, event page tests, etc.
It would also help to involve more students in the project.

@arteevraina
Copy link
Contributor Author

Looks good ! I am currently writing widget tests for login_page.dart

@shauravshikhar
Copy link
Contributor

can i help @arteevraina @Sagar2366 ?
i will love to help

@arteevraina
Copy link
Contributor Author

Hi @shikharsaurav! You can contribute unit/widget tests but make sure to update here to avoid any duplicacy of work. I am waiting for #462 to merge after that I will add some more tests for url_page.dart.

@utkarshshendge
Copy link
Contributor

Hi @arteevraina , I am trying to write tests for newsArticle.dart and newsfeed.dart.

@arteevraina
Copy link
Contributor Author

arteevraina commented Mar 23, 2021

Hi @utkarshshendge ! It would be better if you handle one widget in a single PR. So that other participants can also get involved :)

I see that test for newsArticle has already been written. Please cross check before sending a patch in order to avoid any duplicate work.

In the meantime, I will write tests for register_page.dart.

@utkarshshendge
Copy link
Contributor

In order to write tests for newsfeed.dart we will have to write test for addPost.dart.
I'm writing for addPost.dart.
if anyone wants to write tests for newsfeed.dart feel free to do after tests for addPost.dart get merged.

@utkarshshendge
Copy link
Contributor

Hey @arteevraina could you please add link to the test folder in this comment #326 (comment) ?

@utkarshshendge
Copy link
Contributor

Im adding widget tests for home_page.dart

@dhushyanth-s
Copy link

I'm adding tests for newsfeed.dart file.

@arteevraina
Copy link
Contributor Author

I will be working on the widget test for join organization page.

Ayush0Chaudhary pushed a commit to Ayush0Chaudhary/talawa that referenced this issue Mar 29, 2023
* added role based authorization directive

* fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

8 participants