Proper State Management (Removal of pull to refresh )

[ishan0805]

Description

I think pull to refresh can be avoided by proper state management . As of now manually a request is made again and again to fetch data when page is reloaded .

Solution

Inside preference provider we can define a function that return the list of post with a 'listener()' so that whenever a new post is created that is displayed automatically without explicitly pulling the page to refresh .
OR
It can also be solved by using Streams , using BehaviorSubject Observable provided by Redux , witch is a better way of doing it as it sends the very last event that was emitted to the listener that just subscribed but as the app is build mostly with provider it will not match the MVVM design .

Benefits

1. By following this approach multiple calling of setstate() can be avoided . As the number of news increase it will be more optimal .
2. As list of news will be provided by preference Provided , it will be globally available for every widget below root.
3. It will remove the logic part from the UI part hence improve testing and become more readable .

[yasharth291]

Hello @ishan0805 actually i think you are not working on the recent code because the thing i can see on the screenshot is old and can create problem with my merge please see mentors

[yasharth291]

And i think it is resolved in the current code base

[ishan0805]

ok I will check that , thanks for the information .

[ishan0805]

@yasharth291 only the pull to remove text is removed the functionally is still the same . Now user need to pull himself without knowing if its news is posted or not . Don't worry I saw you have made changes to the UI and I am talking about flow of data , it will not affect your code

WhatsApp.Video.2021-03-16.at.11.14.16.AM.mp4

[Sagar2366]

@ishan0805 you can start working on this issue. Consider this case also while working on this issue - #300

[Sagar2366]

@piyushpradhan as discussed in slack channel please start working on this issue.

[piyushpradhan]

Yes, I'm on it.

[Sagar2366]

@piyushpradhan because of no activity on this issue, we will have to un-assign this issue and let someone else work on it.

[StrangeNoob]

@Sagar2366 I am working on it with @piyushpradhan. Can you assign this to me ?

[Sagar2366]

@Sagar2366 I am working on it with @piyushpradhan. Can you assign this to me ?

@StrangeNoob any progress on this issue ?
Can you please raise PR and add issue number to it.

@ishan0805 wait for some time, do not start working on this issue.

[StrangeNoob]

@Sagar2366 I started working on it yesterday. I will let you know by tomorrow. Is it Okay?

[Sagar2366]

@StrangeNoob did we discussed about you would be working on this issue in slack ?
If yes raise PR With whatever work is done.

[StrangeNoob]

closes #334 via #518

[CyberWake]

@ishan0805 we have implemented the mvvm in the application and we are further optimising the code base this issue will be resolved uder #850 . may we close this issue?

[CyberWake]

@palisadoes sir we can close this issue as #850 will handle this one and resolve the same.