Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] - Tab bar pages not refreshed automatically on org switching and edge case not handled #514

Closed
CyberWake opened this issue Mar 25, 2021 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@CyberWake
Copy link
Contributor

CyberWake commented Mar 25, 2021

  • Issue Description:
    State not handled properly in members page. And inappropriate message.
    On suggestions as asked by @Sagar2366 sir here
    Auto refreshing of event page, feeds page, and chats

  • Issue Severity:
    High.

  • Environment Details:
    Home page-> Members tab
    Visit it directly on app launch. Now go to the profile page switch the organization again visit members tab page is not refreshed.
    Now leave/remove all the organizations than visit member page page doesn't get refreshed automatically as well as on pulling down to refresh refresh button is visible which should not be there as the user in not in any organization.
    Switch the current org to new one still the tab bar pages show data relevant to previous organization.
    Not specific to members page all the pages on tab bar don't refresh automatically on change in current organization data

  • Observed Behaviour:
    Even if the user is not in organization he see a refresh button which is of no use to him. Comes handy only in case of internet connectivity that to for the user who has joined at least on organization. The all tab bar page doesn't update automatically on change in current organization.

  • Expected Behaviour:
    There should not me refresh button if the user is not joined any organization something more meaning full should be displayed.
    tab bar page should automatically update on change with current organization.

  • Steps to reproduce issue:
    Follow the video and it has more ways as well you may direct visit without joining any organization or vice versa.

  • Snapshots/Videos:
    Attaching a demo video.

  • Does this issue need immediate attention?
    Yes, this need to be resolved so that the user doesn't see inappropriate data.

  • Are you willing to work on this issue:
    Yes, I am will to work on this issue.

  • Other information:
    @Sagar2366 sir please assign this issue to me.

@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Mar 25, 2021
@pr4nshul
Copy link
Contributor

Yes, this needs to be worked on. This issue in the comments of issue #307. As mentioned there, this could give user a feeling of not being a able to switch org or even leave org. Because this issue is still there even if user leaves a org.

@CyberWake
Copy link
Contributor Author

i have fixed this one. need to make a PR after getting assigned

@pr4nshul
Copy link
Contributor

Nice 👍 , I am not looking to work on it. I was just mentioning I faced a similar issue. And this needs immediate attention 💯

@CyberWake
Copy link
Contributor Author

can you fetch the master the issue marked in #307 was resolved with the merge of #355

@pr4nshul
Copy link
Contributor

That's not what I meant if you would read the comments. I mentioned something similar to your issue. I am on the latest master. Appreciate your effort to help though! 👍

@CyberWake
Copy link
Contributor Author

@Sagar2366 please review the PR #519 . Don't know why it didn't got linked with the issue.🙂

CyberWake added a commit to CyberWake/talawa that referenced this issue Apr 4, 2021
@CyberWake CyberWake mentioned this issue Apr 4, 2021
@CyberWake CyberWake changed the title [Bug] - Member page not refreshed automatically on org switching and edge case not handled [Bug] - Tab bar pages not refreshed automatically on org switching and edge case not handled Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants