Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization Settings Page #355

Closed
CyberWake opened this issue Mar 16, 2021 · 9 comments
Closed

Organization Settings Page #355

CyberWake opened this issue Mar 16, 2021 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@CyberWake
Copy link
Contributor

I encountered an issue with the new organization settings page implemented.

  1. It doesn't allow me as a member to leave any organization. [Bug]
    https://thepalisadoes-dyb6419.slack.com/files/U01QZEFJSCE/F01QYUR2A3H/t_video6235250589085729285__1_.mp4
  2. As a member this page should be adaptive accordingly like it should either show me the toast in remove member page on marking any member for remove or it should not show me the options to remove member in the organization page. [Enhancement]
    https://thepalisadoes-dyb6419.slack.com/files/U01QZEFJSCE/F01RDN4F57U/photo6235250589541969025.jpg
  3. Accept membership request should only be visible to private organizations that too only if the user is admin. Adding to this one the page loads empty if there are no member join requests, displaying a proper message would be a better choice. [Enhancement]
  4. As a organization admin, if a remove a user and if the user happens to be a admin then there's a feature which prevents this to happen but I feel this could be enhanced by either displaying a proper toast or we can show on the member name tile itself if the user is admin similar to whatsapp. This could also help other members as well to know who are there organization's admins. [Feature/Enhancement]
    https://user-images.githubusercontent.com/44184786/111338728-2c878b00-869d-11eb-822d-88f3bbd9d1ae.jpg
  5. Update organization option should only be visible if the user is admin [Feature]
    https://thepalisadoes-dyb6419.slack.com/files/U01QZEFJSCE/F01RDN4F57U/photo6235250589541969025.jpg

Console log for the same:
image
Video of the same:

t_video6235250589085729313.mp4
@CyberWake
Copy link
Contributor Author

@Sagar2366 @jordanliu can you please assign me this issue. I would be very happy to contribute on the following issue.

@palisadoes palisadoes added the unapproved Unapproved, needs to be triaged label Mar 16, 2021
@jordanliu jordanliu removed the unapproved Unapproved, needs to be triaged label Mar 17, 2021
@CyberWake
Copy link
Contributor Author

Thank you @Sagar2366 sir. Working on it.😊

@Sagar2366 Sagar2366 added the bug Something isn't working label Mar 17, 2021
@shauravshikhar
Copy link
Contributor

@Sagar2366 @jordanliu can i work on 1st bug i would love to contribute

@CyberWake
Copy link
Contributor Author

@shikharsaurav sorry to interrupt but the point you are taking about is dependent on backend. We have a issue raised over there on tawala-api once we have that fixed we'll be able to eradicate that thing. ✌

@Sagar2366
Copy link
Contributor

@CyberWake some of these are actually good suggestions.
Can you create 5 different issues ? Let me know if you have started already working on any of them.

@CyberWake
Copy link
Contributor Author

@Sagar2366 this is a PR already made to resolve all these issues. Please review it, added I have provided the screenshot/recordings for the requested changes that would arrive after the merge.

@Sagar2366
Copy link
Contributor

@Sagar2366 this is a PR already made to resolve all these issues. Please review it, added I have provided the screenshot/recordings for the requested changes that would arrive after the merge.

@CyberWake I am doing it for now and last time.
Please follow the guidelines, break down issues if possible. Send small PR's for review, don't mix fox for all issues in same PR.
I'm future if anything breaks it will be difficult to analyse the issue.
As suggested in PR remove changes which should not be added to fix the issue, any code formatting, re-factoring, etc.

@CyberWake
Copy link
Contributor Author

ok sir. will take care this isn't repeated again.

@yasharth291
Copy link
Contributor

yasharth291 commented Mar 21, 2021

i think this is duplicate #230 the 3rd point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants