-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Like Button experience #769
Labels
unapproved
Unapproved, needs to be triaged
Comments
@Sagar2366, @palisadoes I would like to work on this. |
Closing this because this is done in the code rewrite. |
Ayush0Chaudhary
pushed a commit
to Ayush0Chaudhary/talawa
that referenced
this issue
Mar 29, 2023
* Removed package easygraphql-tester (PalisadoesFoundation#747) Removed the package named easygraphql-tester because it was not being used anywhere in the app and had a security vulnerability. * Revert "Removed package easygraphql-tester (PalisadoesFoundation#747)" (PalisadoesFoundation#753) This reverts commit 61818a1e6484f39b66bd3105ca2dda8d7396f62f. * Bump moment-timezone from 0.5.34 to 0.5.37 (PalisadoesFoundation#757) Bumps [moment-timezone](https://github.com/moment/moment-timezone) from 0.5.34 to 0.5.37. - [Release notes](https://github.com/moment/moment-timezone/releases) - [Changelog](https://github.com/moment/moment-timezone/blob/develop/changelog.md) - [Commits](moment/moment-timezone@0.5.34...0.5.37) --- updated-dependencies: - dependency-name: moment-timezone dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Doubled the number of retries The tests have been failing due to timeouts. * add mongodb credentials in github actions yml file * update github actions mongodb parameters * update variable names in github actions * update github actions push file * revert github actions push file * add start period for health check in github actions * add extra health check parameters for mongo * adjust mongo image version * explicitly add mongo version to image for github actions * Removed package easygraphql-tester (PalisadoesFoundation#754) * Code Coverage : Tests for groups.js Fix PalisadoesFoundation#585 (PalisadoesFoundation#769) * Create groups.spec.js * Update groups.spec.js * Update getPlugins.spec.js * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Bump jose from 2.0.5 to 2.0.6 (PalisadoesFoundation#770) Bumps [jose](https://github.com/panva/jose) from 2.0.5 to 2.0.6. - [Release notes](https://github.com/panva/jose/releases) - [Changelog](https://github.com/panva/jose/blob/v2.0.6/CHANGELOG.md) - [Commits](panva/jose@v2.0.5...v2.0.6) --- updated-dependencies: - dependency-name: jose dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump file-type and image-hash (PalisadoesFoundation#752) Bumps [file-type](https://github.com/sindresorhus/file-type) and [image-hash](https://github.com/danm/image-hash). These dependencies needed to be updated together. Updates `file-type` from 14.7.1 to 16.5.4 - [Release notes](https://github.com/sindresorhus/file-type/releases) - [Commits](sindresorhus/file-type@v14.7.1...v16.5.4) Updates `image-hash` from 4.0.1 to 5.3.1 - [Release notes](https://github.com/danm/image-hash/releases) - [Commits](https://github.com/danm/image-hash/commits) --- updated-dependencies: - dependency-name: file-type dependency-type: indirect - dependency-name: image-hash dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump got and nodemon (PalisadoesFoundation#771) Bumps [got](https://github.com/sindresorhus/got) and [nodemon](https://github.com/remy/nodemon). These dependencies needed to be updated together. Removes `got` Updates `nodemon` from 2.0.15 to 2.0.20 - [Release notes](https://github.com/remy/nodemon/releases) - [Commits](remy/nodemon@v2.0.15...v2.0.20) --- updated-dependencies: - dependency-name: got dependency-type: indirect - dependency-name: nodemon dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump vm2 from 3.9.9 to 3.9.11 (PalisadoesFoundation#772) Bumps [vm2](https://github.com/patriksimek/vm2) from 3.9.9 to 3.9.11. - [Release notes](https://github.com/patriksimek/vm2/releases) - [Changelog](https://github.com/patriksimek/vm2/blob/master/CHANGELOG.md) - [Commits](patriksimek/vm2@3.9.9...3.9.11) --- updated-dependencies: - dependency-name: vm2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Feature Request : Performing Donations ( Ability to store donation transaction in Talwa-api ) (PalisadoesFoundation#756) * Test : lib/resolvers/group_chat_query/groupChatMessages.js * Add Test : Added Valid JSON Check * Create README.md * Create README.md * Update is-auth.js * AddedDocs Docs from withfilter pending * Update index.js * completed * sample * update/index.js * update/index.js * update/is-auth.js * Update/readme.md * update/image-readme * Add/query-schema * Update/Plugin-graphQL-schema * Add/Plugin-MongoDB-Model * Add/createPlugin-and-refractoring * Add/getPlugins * Add/Mutation/UpdatePluginStatus * Add/Mutation/updateTempPluginInstalledOrgs * Add/Mutation/Schema * Add/import/mutations * Add/plugins * Fix/path-err * Fix/Erros * update/lockfile * Add/plugin-model * Update is-auth.js * Removed extra queries * Documentation added for plugin queries and models * Fix/`delelte cr in prettier/prettier` * updated : mutation * Add/test `getPlugins` * Fix/`lint error` * test `updatePluginInstalledOrgs` * Test/ `updateInstallStatus` * Fix/Erros-1 * Fix/Erros-2 * Fix/Erros-3 * Test/`Queries.js` * Test/`Mutation.js` * remove extra `console.log` * Delete admin-plugin-query.js * Delete super-admin-plugin-query.js * Fix/Package-lock * Create cancel_membership_request.spec.js * Update cancel_membership_request.js * Update cancel_membership_request.spec.js * Update cancel_membership_request.js * `Typo` * Add : Donation Model * Add : getDonations Query * Add : Schema for Donation * Add : Schema for getDonations query * Add : getDonationById Query * Add : Schema for getDonationById * Fix : `Donation Model` * Add : createDonation Mutation * Add : createDonation Schema * Updated Donation Model * Add : `createDonation` GraphQL Mutation * Fix : `getDonationById` Query * Add : `getDonationByOrgId` Query * Update : Scehma Updated due to change in `Donation` Model * Update : `Donation` Schema in .graphql * Add : `getDonationById` and `getDonationByOrgId` in gql schema * Add : gql Schema for `DeletePayload` * Add : `deleteDonationById` Mutation * Chores : Formatting files * Fix : Lint errors * Test for send_membership_request.js (PalisadoesFoundation#763) * test for reject_membership_request.js * send_membership_request.spec.js initialized * test for send_membership_request.js * fixes in test for send membership request * minor fixes in send_membership_request.spec.js * 100% test coverage Co-authored-by: Nishant <srnikhil3721@gmai.com> * Talawa api multitenancy (PalisadoesFoundation#776) * Initial setup (PalisadoesFoundation#726) * Initial setup * simplified creation * added readme.md file * added connection manager and id helper functions * Error handling & security updates (PalisadoesFoundation#744) * [Feature Request] New Features for Talawa-admin added (PalisadoesFoundation#725) * check authentication feature added for talawa admin * tests for check authentication added * minor fixes * typo fixes * minor fixes * npm err fixes * google recaptcha configured * new dependency added * mailer, forgotPassword endpoint and otp endpoint is configured * graphql endpoints updated * constants updated * Documentation updated * tests for changes added * hard coded value error fixes * lint fixes * lint fixes * failed test cases fixes * Failed tests fixes * minor fixes * marked-teminal dependency updated * Tests fixes * tests updated * tests fixes * tests updated * new resolvers added and schema updated * graphql mutations updated * tests updated for changes * tests updated * tests updated * tests updated * minor fixes * [Feature Request] : Plugin Architecture for Server (PalisadoesFoundation#730) * Test : lib/resolvers/group_chat_query/groupChatMessages.js * Add Test : Added Valid JSON Check * Create README.md * Create README.md * Update is-auth.js * AddedDocs Docs from withfilter pending * Update index.js * completed * sample * update/index.js * update/index.js * update/is-auth.js * Update/readme.md * update/image-readme * Add/query-schema * Update/Plugin-graphQL-schema * Add/Plugin-MongoDB-Model * Add/createPlugin-and-refractoring * Add/getPlugins * Add/Mutation/UpdatePluginStatus * Add/Mutation/updateTempPluginInstalledOrgs * Add/Mutation/Schema * Add/import/mutations * Add/plugins * Fix/path-err * Fix/Erros * update/lockfile * Add/plugin-model * Update is-auth.js * Removed extra queries * Documentation added for plugin queries and models * Fix/`delelte cr in prettier/prettier` * updated : mutation * Add/test `getPlugins` * Fix/`lint error` * test `updatePluginInstalledOrgs` * Test/ `updateInstallStatus` * Fix/Erros-1 * Fix/Erros-2 * Fix/Erros-3 * Test/`Queries.js` * Test/`Mutation.js` * remove extra `console.log` * Delete admin-plugin-query.js * Delete super-admin-plugin-query.js * Fix/Package-lock * added delimiter to helper functions * error handling for connection manager * added readme.md for connection manager * error handling for Database module Co-authored-by: Asmit Kumar Sirohi <63240102+asmitsirohi@users.noreply.github.com> Co-authored-by: Siddhesh Bhupendra Kuakde <65951872+SiddheshKukade@users.noreply.github.com> * Create new tenant on createOrganization * Custom schema functionality * Added the context function * modify createPost resolver * fix createPost, createOrganization resolvers * Initial setup (PalisadoesFoundation#726) * Initial setup * simplified creation * added readme.md file * added connection manager and id helper functions * Error handling & security updates (PalisadoesFoundation#744) * [Feature Request] New Features for Talawa-admin added (PalisadoesFoundation#725) * check authentication feature added for talawa admin * tests for check authentication added * minor fixes * typo fixes * minor fixes * npm err fixes * google recaptcha configured * new dependency added * mailer, forgotPassword endpoint and otp endpoint is configured * graphql endpoints updated * constants updated * Documentation updated * tests for changes added * hard coded value error fixes * lint fixes * lint fixes * failed test cases fixes * Failed tests fixes * minor fixes * marked-teminal dependency updated * Tests fixes * tests updated * tests fixes * tests updated * new resolvers added and schema updated * graphql mutations updated * tests updated for changes * tests updated * tests updated * tests updated * minor fixes * [Feature Request] : Plugin Architecture for Server (PalisadoesFoundation#730) * Test : lib/resolvers/group_chat_query/groupChatMessages.js * Add Test : Added Valid JSON Check * Create README.md * Create README.md * Update is-auth.js * AddedDocs Docs from withfilter pending * Update index.js * completed * sample * update/index.js * update/index.js * update/is-auth.js * Update/readme.md * update/image-readme * Add/query-schema * Update/Plugin-graphQL-schema * Add/Plugin-MongoDB-Model * Add/createPlugin-and-refractoring * Add/getPlugins * Add/Mutation/UpdatePluginStatus * Add/Mutation/updateTempPluginInstalledOrgs * Add/Mutation/Schema * Add/import/mutations * Add/plugins * Fix/path-err * Fix/Erros * update/lockfile * Add/plugin-model * Update is-auth.js * Removed extra queries * Documentation added for plugin queries and models * Fix/`delelte cr in prettier/prettier` * updated : mutation * Add/test `getPlugins` * Fix/`lint error` * test `updatePluginInstalledOrgs` * Test/ `updateInstallStatus` * Fix/Erros-1 * Fix/Erros-2 * Fix/Erros-3 * Test/`Queries.js` * Test/`Mutation.js` * remove extra `console.log` * Delete admin-plugin-query.js * Delete super-admin-plugin-query.js * Fix/Package-lock * added delimiter to helper functions * error handling for connection manager * added readme.md for connection manager * error handling for Database module Co-authored-by: Asmit Kumar Sirohi <63240102+asmitsirohi@users.noreply.github.com> Co-authored-by: Siddhesh Bhupendra Kuakde <65951872+SiddheshKukade@users.noreply.github.com> * dynamic functionality additions * update tenant schema folder * modify all posts-comments resolvers * resolve failing tests for posts modifications * modify events-tasks-projects related resolvers * resolve failing tests * modified user queries * modify longin mutation to return events properly * modify org mutations and resolve failing tests * diconnect properly from the database * if not connection for org search in the database for it * group chats and direct chats mutations * remove console logs * remove unnecessary comments * fix drop database Co-authored-by: Mickey <31347338+JamaicanFriedChicken@users.noreply.github.com> Co-authored-by: Asmit Kumar Sirohi <63240102+asmitsirohi@users.noreply.github.com> Co-authored-by: Siddhesh Bhupendra Kuakde <65951872+SiddheshKukade@users.noreply.github.com> Co-authored-by: JamaicanFriedChicken <mikey_lue777@hotmail.com> * interchanged .env and .env.sample from the installation guide (PalisadoesFoundation#774) * Migrated develop branch to typescript including the changes till october 19, 2022 * Added some comments and reinstalled some packages to match the main repository's package.json * Github actions update * getLanguage.spec.ts import fix * forgotPassword.spec.ts fix Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Peter Harrison <blackriver@simiya.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JamaicanFriedChicken <mikey_lue777@hotmail.com> Co-authored-by: Siddhesh Bhupendra Kuakde <65951872+SiddheshKukade@users.noreply.github.com> Co-authored-by: Nishant Singh <76558924+nishant3721@users.noreply.github.com> Co-authored-by: Nishant <srnikhil3721@gmai.com> Co-authored-by: Ebrahim <74679570+ebrahim354@users.noreply.github.com> Co-authored-by: Mickey <31347338+JamaicanFriedChicken@users.noreply.github.com> Co-authored-by: Asmit Kumar Sirohi <63240102+asmitsirohi@users.noreply.github.com> Co-authored-by: Kanishka Bansode <96020697+kb-0311@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Currently, it takes time to update the like count when the user taps on the
like
button. If you see Apps like Instagram, LinkedIn you can see that the like count is updated as soon as the user taps on thelike
button. Also there is no proper exception handling for like funtionality.Describe the solution you'd like
We can update the UI as soon as user taps on like button If there is a problem while adding likes the user will be notified and the like count will be updated. In short :
Update on front end, send to back end, re-render on front end based on the response from backend.
Describe alternatives you've considered
A request queue using a offline database, preferably Hive db. Instagram does something similar to this, if you like posts and go offline, a message will be displayed
Likes will be updated when you are back online.
Additional context
Current Screenshot:
2021_05_09_19_45_13.mp4
The text was updated successfully, but these errors were encountered: