-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'class' label and argument, add default email/provider arguments #39
Conversation
Insert correct challenge provider into error message
…space(s), only resources labelled with the configured 'class' label value are managed Implement default provider and default email options, that are used except when overridden by the corresponding Certficate fields or annotations on Ingresses Add log messages when creating or updating a Secret Make prefix for labels and annotations able to be overridden with -tagPrefix Make namespace for Certificate resource able to be overridden with -certNamespace Correct syntax for setting Lego ACME HTTP and HTTPS challenge ports
Sorry for the delay on this, I will make sure to review this this weekend |
Everything looks good! One question: can we come up with a better name than "class" ? it doesn't feel super fit for purpose for what it does. I'd also like to see a documentation update before we release this, but as everything keeps working as before without any arguments, this can potentially wait, though I rather it wouldn't. |
Thank @luna-duclos! I considered the label choice pretty carefully and went back and forth on several options before settling on "class" because:
I was careful to keep everything backwards compatible with the old version and existing documentation. I considered also updating the documentation with this, but if I did, I'd want to simultaneously remove or annex the deprecated stuff (like 'enabled') and only document that new way of doing things. If you don't mind that, I can look at the documentation over the next week or so. I'd edit it in Github, so there probably be a huge stack of commits generated. Though you can squash the PR. |
Thanks for this! The |
When would you have time to look at docs ? I was hoping to get this in before dropping a 1.5 version |
@luna-duclos I have this post-it-note on my monitor, so it is all in hand 😃 |
…fault email and provider arguments Add documentation of the deprecated Ingress 'enabled' annotation Add complete documentation of all deployment arguments Update the documentation and sample 'deployment.yaml' in preparation for a 0.5.0 release Change the default `-class` argument value to 'default', enabling the class label behavior be default (can set to blank for backwards compatibility) Add special upgrade note to README.md for people using the old `enabled` annotation behavior
Ok @luna-duclos I have updated all the documentation and examples for the 'class' label and the new default email/provider arguments. I updated everything ready for 0.5.0 and made the |
Read over it, looks good! Will try it out sunday and merge |
As of PalmStoneGames#39, resources need labels so that different kcm instances handle them.
As of #39, resources need labels so that different kcm instances handle them.
The
-class
label allows multiple kcm's in the same namespace(s) for different DNS accounts. If the new-class
argument is not specified, then kcm remains backwards compatible. If-class
is specified, then the 'enabled: true` annotation is deprecated. See #30 for more details on the behaviour.Added
-tag-prefix
and-cert-namespace
to allow backwards compatibility after the project moves to a new repository. See #33 for more details.I've be running multiple instances of this version in pre-production for a bit, working well with both DNS and HTTP challenges.