Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify to work with snap-0.10 #9

Merged
merged 1 commit into from
Jan 2, 2013
Merged

Modify to work with snap-0.10 #9

merged 1 commit into from
Jan 2, 2013

Conversation

zopa
Copy link
Contributor

@zopa zopa commented Dec 30, 2012

Two notes:

  • Personally, I don't think the direct dependency on the lens package is a big deal,
    since snap already depends on lens. But it could be avoided pretty easily, at the
    cost of somewhat uglier code.
  • This compiles, it's straightforward, and it looks right to me. But I haven't tested
    it otherwise.

snap-0.10 uses the lens package instead of data-lens, so we use
lens package lenses in M.hs. Also remove some unnecessary imports
in S.hs, bump the snap dependency, and add a direct dependency on
the lens package. (The last is needed because we're using functions
from Control.Lens that Snap does not re-export.)

snap-0.10 uses the lens package instead of data-lens, so we use
lens package lenses in M.hs. Also remove some unnecessary imports
in S.hs, bump the snap dependency, and add a direct dependency on
the lens package. (The last is needed because we're using functions
from Control.Lens that Snap does not re-export.)
Palmik added a commit that referenced this pull request Jan 2, 2013
Modify to work with snap-0.10
@Palmik Palmik merged commit 0627e27 into Palmik:master Jan 2, 2013
@Palmik
Copy link
Owner

Palmik commented Jan 2, 2013

Thank you for your contribution. I have merged your code and uploaded new version to Hackage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants